From kde-core-devel  Wed Apr 13 08:10:42 2011
From: Thiago Macieira <thiago () kde ! org>
Date: Wed, 13 Apr 2011 08:10:42 +0000
To: kde-core-devel
Subject: Re: Review Request: Fix a VLC crash by delaying object deletion to
Message-Id: <2936292.Vp6tDNP5Jf () lothlorien>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130268229205730
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart3355690.VuJQeUaQnM"


--nextPart3355690.VuJQeUaQnM
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

I can't reproduce the crash anymore.

I'm getting a different error with Qt 4.8. It seems VLC is now trying t=
o=20
closeAllWindows after QApplication is gone.

Em ter=E7a-feira, 12 de abril de 2011, =E0s 22:22:10, Dawit Alemayehu e=
screveu:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100577/
> -----------------------------------------------------------
>=20
> (Updated April 12, 2011, 10:22 p.m.)
>=20
>=20
> Review request for kdelibs and Thiago Macieira.
>=20
>=20
> Changes
> -------
>=20
> Thiago,
>=20
> A reminder for you to look into this crash when you get a chance[1].
> Otherwise, we would have to commit the workaround patch posted in thi=
s
> review.
>=20
> [1] http://lists.kde.org/?l=3Dkde-core-devel&m=3D129693527318658&w=3D=
2
>=20
>=20
> Summary
> -------
>=20
> As described in the bug report when opening the file dialog, cancelin=
g it
> and exiting VLC causes the application to seg fault. The backtraces p=
osted
> in the bug report shows that the crash happens somewhere in QtDBus an=
d I
> get a similar backtrace when using v1.1.7 of this application.
>=20
> When I looked into this issue what I discovered was that only KIO cla=
sses
> that register themselves with QtDBus cause the crash. I only found th=
at out
> because fixing the crash in KIO::Scheduler by defering its deletion u=
sing
> deleteLater() did not prevent the application from still crashing on =
exit.
> However, the crash had moved to another location, KBookmarkManager. T=
he
> only common thing between the crash at KBookmarkmanager and KIO::Sche=
duler
> was that in both cases the backtrace shows QtDBus attempting to invok=
e or
> access some method or slot in the object that was just destroyed. At =
this
> point I decided to check how many other classes in KIO register thems=
elves
> with QtDBS and found only one and applied the same change to all thre=
e,
> defer deletion of any object registered with QtDBus using
> QObject::deleteLater.
>=20
> Anyhow, I have no idea why the crashes are only seen with this applic=
ation.
> I was not able to duplicate the crash using the same sequences in ano=
ther
> Qt only app, Arora and none of the KDE applications I tried.
>=20
>=20
> This addresses bug 234484.
>     http://bugs.kde.org/show_bug.cgi?id=3D234484
>=20
>=20
> Diffs
> -----
>=20
>   kio/kio/scheduler.cpp d5fab85
>   kio/bookmarks/kbookmarkmanager.cc 9086fd2
>   kio/kio/fileundomanager.cpp ca1cbbb
>=20
> Diff: http://git.reviewboard.kde.org/r/100577/diff
>=20
>=20
> Testing
> -------
>=20
>=20
> Thanks,
>=20
> Dawit
--=20
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

--nextPart3355690.VuJQeUaQnM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQBNpVqCM/XwBW70U1gRAgCIAJwLMvruhcyxMsjiH6UbSvL5XFM3vgCgu05L
T+UDSajA3JTyKj9lDe1ETN4=
=t+f3
-----END PGP SIGNATURE-----

--nextPart3355690.VuJQeUaQnM--