[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Add missing KAuthorize "hooks" on KFileItemActions
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2011-04-11 12:22:28
Message-ID: 20110411122228.17244.11391 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101082/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
I found 2 places where KAuthorize should be added:
KFileItemActions::addOpenWithActionsTo(QMenu* topMenu, const QString& trade=
rConstraint)
In this method as you can see, the first option is a QMenu pointer where th=
e new "open with" actions will be added. If we don't check in this function=
if "openwith" is allowed we will end up having "Open with" action (or havi=
ng to patch all apps :p)
The second place is: =
KFileItemActionsPrivate::slotExecuteService(QAction* act)
This is where the actual action is executed, just for """""security""""" an=
d robustness we should check here too.
Diffs
-----
kio/kio/kfileitemactions.cpp 7f7d5c9 =
Diff: http://git.reviewboard.kde.org/r/101082/diff
Testing
-------
Thanks,
Alex
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101082/">http://git.reviewboard.kde.org/r/101082/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Alex Fiestas.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I found 2 places where KAuthorize should be added: \
KFileItemActions::addOpenWithActionsTo(QMenu* topMenu, const QString& \
traderConstraint)
In this method as you can see, the first option is a QMenu pointer where the new \
"open with" actions will be added. If we don't check in this function \
if "openwith" is allowed we will end up having "Open with" action \
(or having to patch all apps :p)
The second place is:
KFileItemActionsPrivate::slotExecuteService(QAction* act)
This is where the actual action is executed, just for \
"""""security""""" and robustness \
we should check here too.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/kfileitemactions.cpp <span style="color: grey">(7f7d5c9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101082/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic