[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: KIO Proxy Support Overhaul Part II: KProtocolManager &
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2011-04-06 4:31:35
Message-ID: 20110406043135.6450.64627 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101037/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
This the second part of a series of patches designed to improve and bring K=
IO's proxy support to the levels of KDE 3.5 and beyond. Unlike the first se=
ries, https://git.reviewboard.kde.org/r/100971/, these set of patches are f=
ocused on the two classes in KIO that are responsible for providing proxy i=
nformation to all ioslaves, KProtocolManager and KIO::Scheduler. Here are a=
list of the changes contained within:
KProtocolManager:
------------------
* Add socks proxy support to KProtocolManager.
* Add functions for obtaining multiple proxy URL addresses when configured =
through PAC scripts.
* Add support for obtaining system proxy information on Windows and Mac pla=
tforms. [1]
KIO::Scheduler:
---------------
* Set a new meta-data, "ProxyUrls" with a list of comma separated proxy url=
s.[2]
[1] Please note that on Linux/Unix platforms system proxy configuration is =
assumed to be set through enivronment variables and has been supported sinc=
e the days of KDE 2.0.
[2] The existing meta-data "UseProxy" will still be set with the first url =
from the list.
Diffs
-----
kio/kio/scheduler.cpp d657bf6 =
kio/DESIGN.metadata f5dfcd1 =
kio/kio/job_p.h 620e487 =
kio/kio/kprotocolmanager.h 814e2f2 =
kio/kio/kprotocolmanager.cpp 56e1942 =
Diff: http://git.reviewboard.kde.org/r/101037/diff
Testing
-------
Thanks,
Dawit
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101037/">http://git.reviewboard.kde.org/r/101037/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This the second part of a series of patches designed to improve and \
bring KIO's proxy support to the levels of KDE 3.5 and beyond. Unlike the first \
series, https://git.reviewboard.kde.org/r/100971/, these set of patches are focused \
on the two classes in KIO that are responsible for providing proxy information to all \
ioslaves, KProtocolManager and KIO::Scheduler. Here are a list of the changes \
contained within:
KProtocolManager:
------------------
* Add socks proxy support to KProtocolManager.
* Add functions for obtaining multiple proxy URL addresses when configured through \
PAC scripts.
* Add support for obtaining system proxy information on Windows and Mac platforms. \
[1]
KIO::Scheduler:
---------------
* Set a new meta-data, "ProxyUrls" with a list of comma separated proxy \
urls.[2]
[1] Please note that on Linux/Unix platforms system proxy configuration is assumed to \
be set through enivronment variables and has been supported since the days of KDE \
2.0. [2] The existing meta-data "UseProxy" will still be set with the first \
url from the list.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/scheduler.cpp <span style="color: grey">(d657bf6)</span></li>
<li>kio/DESIGN.metadata <span style="color: grey">(f5dfcd1)</span></li>
<li>kio/kio/job_p.h <span style="color: grey">(620e487)</span></li>
<li>kio/kio/kprotocolmanager.h <span style="color: grey">(814e2f2)</span></li>
<li>kio/kio/kprotocolmanager.cpp <span style="color: grey">(56e1942)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101037/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic