[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add a GUI to configure window's title bar blend
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2011-04-03 13:29:19
Message-ID: 20110403132919.15278.66701 () vidsolbach ! de
[Download RAW message or body]
> On March 8, 2011, 2:12 p.m., Hans Meine wrote:
> > kcontrol/colors/colorsettings.ui, line 615
> > <http://git.reviewboard.kde.org/r/100821/diff/1/?file=10768#file10768line615>
> >
> > I believe to recall that "blend" was the term used in the past as well, but given \
> > that not all styles actually use this color for blending, wouldn't it be better \
> > to call it "secondary color"?
> > I.e. "Active Titlebar Secondary [Color/Background]" or the like.
> >
> > I always found this wrong terminology to look unpolished when looking at the \
> > Quartz (IIRC) style.
>
> Christoph Feck wrote:
> Yep, the more generic name sounds better.
>
> Given that there are more colors missing compared to KDE3 (mainly the button \
> colors, which are used, e.g. by deKorator), I would suggest to add them too, and \
> maybe move all window decoration related colors to a separate "section" in the \
> colors KCM, or even to the module where KWin decorations are configured.
> Please add the "kwin" group to reviewers to ask them for their opinion.
from KWin side this is ok, but it hardly influences KWin.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100821/#review1844
-----------------------------------------------------------
On March 8, 2011, 5:23 p.m., Jonathan Marten wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100821/
> -----------------------------------------------------------
>
> (Updated March 8, 2011, 5:23 p.m.)
>
>
> Review request for KDE Base Apps and kwin.
>
>
> Summary
> -------
>
> Some of the still available window decorations (KDE2, Keramik, Modern System, \
> Quartz, Redmond) use two colours for the title bar, either as a blend or for \
> different parts of the bar. This patch extends the GUI in System Settings to allow \
> the blend colour to be configured.
>
>
> This addresses bug 225837.
> http://bugs.kde.org/show_bug.cgi?id=225837
>
>
> Diffs
> -----
>
> kcontrol/colors/colorscm.h 7627db8
> kcontrol/colors/colorscm.cpp 571ed86
> kcontrol/colors/colorsettings.ui efd618b
>
> Diff: http://git.reviewboard.kde.org/r/100821/diff
>
>
> Testing
> -------
>
> Built kde-workspace with these changes, verified operation of systemsettings and \
> KDE2 window decoration.
>
> Screenshots
> -----------
>
> kcontrol screenshot
> http://git.reviewboard.kde.org/r/100821/s/93/
>
>
> Thanks,
>
> Jonathan
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100821/">http://git.reviewboard.kde.org/r/100821/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 8th, 2011, 2:12 p.m., <b>Hans Meine</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100821/diff/1/?file=10768#file10768line615" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcontrol/colors/colorsettings.ui</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">615</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<string>Active Titlebar Blend</string></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I believe to recall that \
"blend" was the term used in the past as well, but given that not all \
styles actually use this color for blending, wouldn't it be better to call it \
"secondary color"?
I.e. "Active Titlebar Secondary [Color/Background]" or the like.
I always found this wrong terminology to look unpolished when looking at the Quartz \
(IIRC) style.</pre> </blockquote>
<p>On March 8th, 2011, 3:51 p.m., <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, the more generic \
name sounds better.
Given that there are more colors missing compared to KDE3 (mainly the button colors, \
which are used, e.g. by deKorator), I would suggest to add them too, and maybe move \
all window decoration related colors to a separate "section" in the colors \
KCM, or even to the module where KWin decorations are configured.
Please add the "kwin" group to reviewers to ask them for their \
opinion.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">from KWin \
side this is ok, but it hardly influences KWin.</pre> <br />
<p>- Martin</p>
<br />
<p>On March 8th, 2011, 5:23 p.m., Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and kwin.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated March 8, 2011, 5:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Some of the still available window decorations (KDE2, Keramik, Modern \
System, Quartz, Redmond) use two colours for the title bar, either as a blend or for \
different parts of the bar. This patch extends the GUI in System Settings to allow \
the blend colour to be configured.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kde-workspace with these changes, verified operation of \
systemsettings and KDE2 window decoration. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=225837">225837</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/colors/colorscm.h <span style="color: grey">(7627db8)</span></li>
<li>kcontrol/colors/colorscm.cpp <span style="color: grey">(571ed86)</span></li>
<li>kcontrol/colors/colorsettings.ui <span style="color: grey">(efd618b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100821/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100821/s/93/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/03/08/225837a_400x100.png" \
style="border: 1px black solid;" alt="kcontrol screenshot" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic