[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Move the KPasswordDialog "Anonymous" checkbox
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-03-22 18:56:17
Message-ID: 20110322185617.27628.90790 () vidsolbach ! de
[Download RAW message or body]
> On March 22, 2011, 6:23 p.m., John Layt wrote:
> > My thoughts are if the anonymous tickbox is first focus it should be ab=
ove the username/password fields and the username/password fields should be=
disabled if anonymous is selected. But that may look a little weird with =
the text to the left and the title below it.
> > =
> > Or does entering a username/password automatically de-select the anonym=
ous? In which case this is fine so long as the username field has the curs=
or focus and pressing enter immediately activates the ok button. =
> > =
> > Or perhaps pre-populate username with 'anonymous' and have the word pre=
-selected so it can be overtyped and do away with the tickbox entirely?
> > =
> > Basically what I'm looking for is the easiest shortest most obvious pat=
h for the main use cases.
> > =
> > </bikeshedding>
> the anonymous tickbox is first focus it should be above the username/pass=
word
+1
> username/password fields should be disabled if anonymous is selected
the problem is about checking the box will disable the UI.
can we maybe drop the checkbox entirely and just QLinedit::setPlaceholderTe=
xt("anonymous") and QLinedit::setPlaceholderText("no password required for=
anonymous login") or sth. like this?
The tab order can btw be controlled explicitly and unrelated to the actual =
layout.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100920/#review2106
-----------------------------------------------------------
On March 22, 2011, 6:04 p.m., Dawit Alemayehu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100920/
> -----------------------------------------------------------
> =
> (Updated March 22, 2011, 6:04 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Summary
> -------
> =
> The attached patch renames and moves the "Anonymous" box shown in the fir=
st screenshot below the password input widgets. This change is done to =
> =
> #1. Remove the checkbox from screwing tab order when you enter username/p=
assword.
> #2. Make the purpose of the checkbox less cryptic to the end user.
> =
> Any objections ?
> =
> =
> Diffs
> -----
> =
> kdeui/dialogs/kpassworddialog.ui 2649870 =
> =
> Diff: http://git.reviewboard.kde.org/r/100920/diff
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> Current Password Dialog
> http://git.reviewboard.kde.org/r/100920/s/106/
> New Password Dialog
> http://git.reviewboard.kde.org/r/100920/s/107/
> =
> =
> Thanks,
> =
> Dawit
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100920/">http://git.reviewboard.kde.org/r/100920/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 22nd, 2011, 6:23 p.m., <b>John Layt</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My thoughts \
are if the anonymous tickbox is first focus it should be above the username/password \
fields and the username/password fields should be disabled if anonymous is selected. \
But that may look a little weird with the text to the left and the title below it.
Or does entering a username/password automatically de-select the anonymous? In which \
case this is fine so long as the username field has the cursor focus and pressing \
enter immediately activates the ok button.
Or perhaps pre-populate username with 'anonymous' and have the word \
pre-selected so it can be overtyped and do away with the tickbox entirely?
Basically what I'm looking for is the easiest shortest most obvious path for the \
main use cases.
</bikeshedding></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> the anonymous \
tickbox is first focus it should be above the username/password +1
> username/password fields should be disabled if anonymous is selected
the problem is about checking the box will disable the UI.
can we maybe drop the checkbox entirely and just \
QLinedit::setPlaceholderText("anonymous") and \
QLinedit::setPlaceholderText("no password required for anonymous login") or \
sth. like this?
The tab order can btw be controlled explicitly and unrelated to the actual \
layout.</pre> <br />
<p>- Thomas</p>
<br />
<p>On March 22nd, 2011, 6:04 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated March 22, 2011, 6:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch renames and moves the "Anonymous" box shown \
in the first screenshot below the password input widgets. This change is done to
#1. Remove the checkbox from screwing tab order when you enter username/password.
#2. Make the purpose of the checkbox less cryptic to the end user.
Any objections ?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/dialogs/kpassworddialog.ui <span style="color: grey">(2649870)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100920/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100920/s/106/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/03/22/current_password_dialog_box_400x100.png" \
style="border: 1px black solid;" alt="Current Password Dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/100920/s/107/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/03/22/new_password_dialog_box_400x100.png" \
style="border: 1px black solid;" alt="New Password Dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic