[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add support for building libplasma with GLES2
From:       Sebastian =?utf-8?q?K=C3=BCgler?= <sebas () kde ! org>
Date:       2011-02-28 13:03:41
Message-ID: 201102281403.42636.sebas () kde ! org
[Download RAW message or body]

On Friday, February 25, 2011 04:29:36 Jammy Zhou wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100705/
> -----------------------------------------------------------
> Update the patch to remove direct OpenGL dependency for libplasma. The
> OpenGL usage in libplasma should better go through libQtOpenGL,which can
> be enabled for desktop OpenGL or OpenGL ES2.0
> 
> Summary
> -------
> 
> After build kwin with GLES2 code path, the kwin binary still has dependency
> on libGL.so, which is introduced by libplasma.so. Then we also need to add
> GLES2 support to libplasma, so that kwin/plasma only has dependency on
> libGLESv2.so in this case.
> 
> The new option "BUILD_PLASMA_WITH_OPENGLES" added in attached patch is
> disabled by default, and distributions can turn it on when do packaging
> for OpenGL ES2.0 support.

Shouldn't that option cover both, kwin and plasma? Or are there serious cases 
where you'd want one, but not the other on opengl-es? If not, let's merge them 
to prevent building and packaging headaches.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
[prev in list] [next in list] [prev in thread] [next in thread]