[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add support for building libplasma with GLES2
From: "Jammy Zhou" <jammy.zhou () linaro ! org>
Date: 2011-02-24 2:07:45
Message-ID: 20110224020745.30407.54365 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100705/
-----------------------------------------------------------
(Updated Feb. 24, 2011, 2:07 a.m.)
Review request for kdelibs and Plasma.
Changes
-------
add plasma-devs for inputs
Summary
-------
After build kwin with GLES2 code path, the kwin binary still has dependency=
on libGL.so, which is introduced by libplasma.so. Then we also need to add=
GLES2 support to libplasma, so that kwin/plasma only has dependency on lib=
GLESv2.so in this case. =
The new option "BUILD_PLASMA_WITH_OPENGLES" added in attached patch is disa=
bled by default, and distributions can turn it on when do packaging for Ope=
nGL ES2.0 support.
Diffs
-----
CMakeLists.txt 2dcc5ec =
cmake/modules/FindOpenGLES.cmake PRE-CREATION =
includes/CMakeLists.txt 9954c37 =
plasma/CMakeLists.txt 8e6b0d7 =
Diff: http://git.reviewboard.kde.org/r/100705/diff
Testing
-------
After turn the "BUILD_PLASMA_WITH_OPENGLES" option on, kwin-gles has no dep=
endency on libGL.so now. And by default, libplasma still depends on libGL.s=
o when run ldd.
Thanks,
Jammy
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100705/">http://git.reviewboard.kde.org/r/100705/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Jammy Zhou.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2011, 2:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">add plasma-devs for inputs</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After build kwin with GLES2 code path, the kwin binary still has \
dependency on libGL.so, which is introduced by libplasma.so. Then we also need to add \
GLES2 support to libplasma, so that kwin/plasma only has dependency on libGLESv2.so \
in this case.
The new option "BUILD_PLASMA_WITH_OPENGLES" added in attached patch is \
disabled by default, and distributions can turn it on when do packaging for OpenGL \
ES2.0 support.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After turn the "BUILD_PLASMA_WITH_OPENGLES" option on, \
kwin-gles has no dependency on libGL.so now. And by default, libplasma still depends \
on libGL.so when run ldd.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2dcc5ec)</span></li>
<li>cmake/modules/FindOpenGLES.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>includes/CMakeLists.txt <span style="color: grey">(9954c37)</span></li>
<li>plasma/CMakeLists.txt <span style="color: grey">(8e6b0d7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100705/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic