--===============2348809223214593746== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100578/#review1453 ----------------------------------------------------------- Any comments? If there are no further objections, I'll commit the patch to = master on Monday the 21. of February. - Peter On Feb. 5, 2011, 7:53 p.m., Peter Penz wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100578/ > ----------------------------------------------------------- > = > (Updated Feb. 5, 2011, 7:53 p.m.) > = > = > Review request for kdelibs and David Faure. > = > = > Summary > ------- > = > Currently KIO::PreviewJob respects the settings "MaximumSize" and "Maximu= mRemoteSize" from the KConfigGroup "PreviewSettings", but completely ignore= s the "Plugins" settings. Because of this in the following locations the pl= ugins are manually read and passed to KIO::PreviewJob: > - Tooltips in Dolphin/Konqueror > - Information Panel in Dolphin > - KFilePreviewGenerator in kdelibs > = > Recently it turned out that the file-open-dialog ignores the "Plugins" to= o. Before adding some code again I've provided this patch for KIO::PreviewJ= ob. Changing the current behavior of KIO::PreviewJob cannot be done, so a n= ew constructor has been added. Following Qt's constructor-pattern the new c= onstructor is quite minimal and setter/getter-methods have been added for t= he missing parameters. > = > The changed behavior of the new constructor is that if enabledPlugins is = zero the plugins from "PreviewSettings" are used now. > = > If it is OK to merge this patch, I'd take care to replace the calls to th= e deprecated API within kdelibs + kdebase. > = > Also it might be useful to change the implementation to use PreviewJob::S= caleType internally instead of the two bools bScale and bSave (the ScaleTyp= e has been introduced because of the KDE5 comment). But I'd do this in a se= cond commit as it won't change any behavior. > = > = > Diffs > ----- > = > kio/kio/previewjob.cpp 96e5b27 = > kio/kio/previewjob.h b86fc9b = > = > Diff: http://git.reviewboard.kde.org/r/100578/diff > = > = > Testing > ------- > = > Temporary adjusted KFilePreviewGenerator for testing. > = > = > Thanks, > = > Peter > = > --===============2348809223214593746== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100578/ 

Any commen=
ts? If there are no further objections, I'll commit the patch to master=
 on Monday the 21. of February.

- Peter


On February 5th, 2011, 7:53 p.m., Peter Penz wrote:

Review request for kdelibs and David Faure.
By Peter Penz.

Updated Feb. 5, 2011, 7:53 p.m.

Descripti= on 

Currently KIO::PreviewJob respects the settings "Maximu=
mSize" and "MaximumRemoteSize" from the KConfigGroup "P=
reviewSettings", but completely ignores the "Plugins" settin=
gs. Because of this in the following locations the plugins are manually rea=
d and passed to KIO::PreviewJob:
- Tooltips in Dolphin/Konqueror
- Information Panel in Dolphin
- KFilePreviewGenerator in kdelibs

Recently it turned out that the file-open-dialog ignores the "Plugins&=
quot; too. Before adding some code again I've provided this patch for K=
IO::PreviewJob. Changing the current behavior of KIO::PreviewJob cannot be =
done, so a new constructor has been added. Following Qt's constructor-p=
attern the new constructor is quite minimal and setter/getter-methods have =
been added for the missing parameters.

The changed behavior of the new constructor is that if enabledPlugins is ze=
ro the plugins from "PreviewSettings" are used now.

If it is OK to merge this patch, I'd take care to replace the calls to =
the deprecated API within kdelibs + kdebase.

Also it might be useful to change the implementation to use PreviewJob::Sca=
leType internally instead of the two bools bScale and bSave (the ScaleType =
has been introduced because of the KDE5 comment). But I'd do this in a =
second commit as it won't change any behavior.

Testing <= /h1> 
Temporary adjusted KFilePreviewGenerator for testing.

Diffs=

  • kio/kio/previewjob.cpp (96e5b27)
  • kio/kio/previewjob.h (b86fc9b)

View Diff
--===============2348809223214593746==--