[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Fix for bug 264444: ksplashx shows garbage when
From: "Ivo Anjo" <knuckles () gmail ! com>
Date: 2011-02-01 23:32:25
Message-ID: 20110201233225.20854.38162 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100520/
-----------------------------------------------------------
Review request for KDE Base Apps and KDE Runtime.
Summary
-------
The base splashimage pixmap/qimage is never initialized, so if for some reason the \
splashscreen doesn't cover the entire screen, you get garbage.
That reason can be a ksplashx theme that does not use multiple monitors on a \
multi-monitor system, or if it picks a background that is smaller than the current \
resolution (for example the Horos splash 1280x1024 version appears to be 1278x1024).
This addresses bug 264444.
http://bugs.kde.org/show_bug.cgi?id=264444
Diffs
-----
ksplash/ksplashx/splash.cpp d6a992a
Diff: http://git.reviewboard.kde.org/r/100520/diff
Testing
-------
I tested this by both replacing the background that ksplashx was using with a smaller \
one, and on two multi-monitor systems (one of which uses a gentoo ksplash screen that \
only covered one of the monitors).
The splash_image.fill( 0 ) can be changed to another color for debugging purposes, \
clearly showing the region of the monitor that is not covered by the splashscreen \
(and where before would be garbage from graphics memory).
Thanks,
Ivo
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100520/">http://git.reviewboard.kde.org/r/100520/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and KDE Runtime.</div>
<div>By Ivo Anjo.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The base splashimage pixmap/qimage is never initialized, so if for some \
reason the splashscreen doesn't cover the entire screen, you get garbage.
That reason can be a ksplashx theme that does not use multiple monitors on a \
multi-monitor system, or if it picks a background that is smaller than the current \
resolution (for example the Horos splash 1280x1024 version appears to be \
1278x1024).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested this by both replacing the background that ksplashx was using \
with a smaller one, and on two multi-monitor systems (one of which uses a gentoo \
ksplash screen that only covered one of the monitors).
The splash_image.fill( 0 ) can be changed to another color for debugging purposes, \
clearly showing the region of the monitor that is not covered by the splashscreen \
(and where before would be garbage from graphics memory).</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=264444">264444</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksplash/ksplashx/splash.cpp <span style="color: grey">(d6a992a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100520/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic