[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add extraction scripts for translatable strings
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2011-01-22 19:47:51
Message-ID: 20110122194751.23360.93658 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6405/#review9679
-----------------------------------------------------------
The names of the scripts are too generic for what they do, can you please m=
ake them less generic?
- Albert
On Jan. 22, 2011, 7:33 p.m., Stephen Kelly wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6405/
> -----------------------------------------------------------
> =
> (Updated Jan. 22, 2011, 7:33 p.m.)
> =
> =
> Review request for kdelibs, Pino Toscano and Chusslove Illich.
> =
> =
> Summary
> -------
> =
> The new scripts allow the kde i18n infrastructure to extract translatable=
strings from Grantlee templates.
> =
> An additional line is needed in the Messages.sh script
> =
> =
> Diffs
> -----
> =
> /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/extract_strings_gettext=
.py PRE-CREATION =
> /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/strings_extractor.py PR=
E-CREATION =
> /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/strings_extractor_gette=
xt.py PRE-CREATION =
> =
> Diff: http://svn.reviewboard.kde.org/r/6405/diff
> =
> =
> Testing
> -------
> =
> Works locally. The code in playground/pim/contacts can be used to test th=
is with x-test once it's checked in.
> =
> =
> Thanks,
> =
> Stephen
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6405/">http://svn.reviewboard.kde.org/r/6405/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The names of the scripts \
are too generic for what they do, can you please make them less generic?</pre> <br \
/>
<p>- Albert</p>
<br />
<p>On January 22nd, 2011, 7:33 p.m., Stephen Kelly wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Pino Toscano and Chusslove Illich.</div>
<div>By Stephen Kelly.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2011, 7:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The new scripts allow the kde i18n infrastructure to extract \
translatable strings from Grantlee templates.
An additional line is needed in the Messages.sh script</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works locally. The code in playground/pim/contacts can be used to test \
this with x-test once it's checked in.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/extract_strings_gettext.py <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/strings_extractor.py <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/strings_extractor_gettext.py \
<span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6405/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic