[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Make KFileDialog update saved file type based on
From: "Lubos Lunak" <l.lunak () kde ! org>
Date: 2011-01-11 16:51:49
Message-ID: 20110111165149.32608.45451 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6325/
-----------------------------------------------------------
Review request for kdelibs, Rafael Fern=C3=A1ndez L=C3=B3pez and David Faur=
e.
Summary
-------
Run e.g. Kolourpaint, do 'Save as', type 'a.xpm' , KFileDialog will automat=
ically select 'XPM' as the saved type. This however doesn't work with all a=
pplications, namely those that use KFileDialog::setFilter() (i.e. only setM=
imeFilter() works this way). This patch implements this feature also for th=
is case.
Diffs
-----
trunk/KDE/kdelibs/kfile/kfilefiltercombo.h 1208060 =
trunk/KDE/kdelibs/kfile/kfilefiltercombo.cpp 1208060 =
trunk/KDE/kdelibs/kfile/kfilewidget.cpp 1208060 =
Diff: http://svn.reviewboard.kde.org/r/6325/diff
Testing
-------
Tried with LibreOffice with KDE4 integration, where this feature works only=
with this patch.
Thanks,
Lubos
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6325/">http://svn.reviewboard.kde.org/r/6325/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Rafael Fernández López and David Faure.</div>
<div>By Lubos Lunak.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Run e.g. Kolourpaint, do 'Save as', type 'a.xpm' , \
KFileDialog will automatically select 'XPM' as the saved type. This however \
doesn't work with all applications, namely those that use \
KFileDialog::setFilter() (i.e. only setMimeFilter() works this way). This patch \
implements this feature also for this case.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tried with LibreOffice with KDE4 integration, where this feature works \
only with this patch. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kfile/kfilefiltercombo.h <span style="color: \
grey">(1208060)</span></li>
<li>trunk/KDE/kdelibs/kfile/kfilefiltercombo.cpp <span style="color: \
grey">(1208060)</span></li>
<li>trunk/KDE/kdelibs/kfile/kfilewidget.cpp <span style="color: \
grey">(1208060)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6325/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic