[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix the inability to put an ioslave on hold when
From: "Andrea Diamantini" <adjam7 () gmail ! com>
Date: 2011-01-04 1:27:59
Message-ID: 20110104012759.16999.45431 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6183/#review9502
-----------------------------------------------------------
trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp
<http://svn.reviewboard.kde.org/r/6183/#comment10504>
I'm studying and testing your patch. I have just a stupid question act=
ually: this "remove hold state" slot seems called just on cancel. Is this o=
k? =
- Andrea
On 2011-01-03 03:49:54, Dawit Alemayehu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6183/
> -----------------------------------------------------------
> =
> (Updated 2011-01-03 03:49:54)
> =
> =
> Review request for kdelibs and Andrea Diamantini.
> =
> =
> Summary
> -------
> =
> The attached patch fixes a long standing issue in the KIO-QNAM class wher=
e actions that require putting an ioslave on hold currently do not work. In=
kdewebkit, which uses this integration class, such actions always occur wh=
en you click on a link that cannot be directly handled by the browsing engi=
ne. For example, clicking on a link that points to a PDF link. Even worse i=
s when the link you click on results in an http POST which returns content.=
In such cases, apps that rely on kdewebkit and hence the KIO-QNAM bridge c=
lass have no way of putting an ioslave on hold as stated in KIO::get's docu=
mentation in order to properly deal with content types they do not support.
> =
> The attached patch along with another pending against kio_http, http://re=
viewboard.kde.org/r/6182/, remedies this issue by adding a means to put rep=
lies on hold and fixing the downloadResponse slot in KWebPage to do the rig=
ht thing.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdelibs/kdewebkit/ISSUES 1211077 =
> trunk/KDE/kdelibs/kdewebkit/kwebpage.h 1211077 =
> trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp 1211077 =
> trunk/KDE/kdelibs/kio/kio/accessmanager.h 1211077 =
> trunk/KDE/kdelibs/kio/kio/accessmanager.cpp 1211077 =
> trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.h 1211077 =
> trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.cpp 1211077 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6183/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Dawit
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6183/">http://svn.reviewboard.kde.org/r/6183/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6183/diff/3/?file=43369#file43369line421" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KWebPage::setWallet(KWebWallet* wallet)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">405</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KIO</span><span class="o">::</span><span class="n">Scheduler</span><span \
class="o">::</span><span class="n">removeSlaveOnHold</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm \
studying and testing your patch. I have just a stupid question actually: this \
"remove hold state" slot seems called just on cancel. Is this ok? </pre> \
</div> <br />
<p>- Andrea</p>
<br />
<p>On January 3rd, 2011, 3:49 a.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Andrea Diamantini.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated 2011-01-03 03:49:54</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch fixes a long standing issue in the KIO-QNAM class \
where actions that require putting an ioslave on hold currently do not work. In \
kdewebkit, which uses this integration class, such actions always occur when you \
click on a link that cannot be directly handled by the browsing engine. For example, \
clicking on a link that points to a PDF link. Even worse is when the link you click \
on results in an http POST which returns content. In such cases, apps that rely on \
kdewebkit and hence the KIO-QNAM bridge class have no way of putting an ioslave on \
hold as stated in KIO::get's documentation in order to properly deal with content \
types they do not support.
The attached patch along with another pending against kio_http, \
http://reviewboard.kde.org/r/6182/, remedies this issue by adding a means to put \
replies on hold and fixing the downloadResponse slot in KWebPage to do the right \
thing.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kdewebkit/ISSUES <span style="color: \
grey">(1211077)</span></li>
<li>trunk/KDE/kdelibs/kdewebkit/kwebpage.h <span style="color: \
grey">(1211077)</span></li>
<li>trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp <span style="color: \
grey">(1211077)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/accessmanager.h <span style="color: \
grey">(1211077)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/accessmanager.cpp <span style="color: \
grey">(1211077)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.h <span style="color: \
grey">(1211077)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.cpp <span style="color: \
grey">(1211077)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6183/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic