[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Adjust the kde "fake" mimetype fonts/package so
From: "David Faure" <faure () kde ! org>
Date: 2010-12-14 12:59:34
Message-ID: 20101214125934.16292.58089 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6111/#review9248
-----------------------------------------------------------
The real question is whether this mimetype is used for files, or only for i=
nternal "fake" purposes. If for files, then it should be added to shared-mi=
me-info (Pino or I can help with that).
But if I remember correctly in this case it's not about files, which is why=
a fake mimetype is used. In that case, I'd rather not reuse an existing fi=
le mimetype, but rather use a kde-specific fake name.
- David
On 2010-12-13 17:07:48, Rex Dieter wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6111/
> -----------------------------------------------------------
> =
> (Updated 2010-12-13 17:07:48)
> =
> =
> Review request for kdelibs.
> =
> =
> Summary
> -------
> =
> This patch adjusts the kde "fake" mimetype fonts/package so desktop-file-=
utils/shared-mime-info doesn't complain (using application/vnd.kde.fontspac=
kage instead). Addresses bugs #235564, #250924
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop =
1206154 =
> /trunk/KDE/kdelibs/mimetypes/kde.xml 1206154 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6111/diff
> =
> =
> Testing
> -------
> =
> confirmed no warnings/errors from desktop-file-utils/shared-mime-info
> =
> =
> Thanks,
> =
> Rex
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6111/">http://svn.reviewboard.kde.org/r/6111/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The real question is \
whether this mimetype is used for files, or only for internal "fake" \
purposes. If for files, then it should be added to shared-mime-info (Pino or I can \
help with that). But if I remember correctly in this case it's not about files, \
which is why a fake mimetype is used. In that case, I'd rather not reuse an \
existing file mimetype, but rather use a kde-specific fake name.</pre> <br />
<p>- David</p>
<br />
<p>On December 13th, 2010, 5:07 p.m., Rex Dieter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated 2010-12-13 17:07:48</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adjusts the kde "fake" mimetype fonts/package so \
desktop-file-utils/shared-mime-info doesn't complain (using \
application/vnd.kde.fontspackage instead). Addresses bugs #235564, #250924</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">confirmed no warnings/errors from \
desktop-file-utils/shared-mime-info</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop <span \
style="color: grey">(1206154)</span></li>
<li>/trunk/KDE/kdelibs/mimetypes/kde.xml <span style="color: \
grey">(1206154)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6111/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic