[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Adds method to KBookmarkManager disable showing
From: "David Faure" <faure () kde ! org>
Date: 2010-12-06 22:13:38
Message-ID: 20101206221338.12074.20175 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6004/#review9157
-----------------------------------------------------------
/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h
<http://svn.reviewboard.kde.org/r/6004/#comment9992>
I would prefer if it was named like the similar method in KDirLister:
/**
* Check whether auto error handling is enabled.
* If enabled, it will show an error dialog to the user when an
* error occurs. It is turned on by default.
* @return true if auto error handling is enabled, false otherwise
* @see setAutoErrorHandlingEnabled()
*/
bool autoErrorHandlingEnabled() const;
/**
* Enable or disable auto error handling is enabled.
* If enabled, it will show an error dialog to the user when an
* error occurs. It is turned on by default.
* If disabled, the application should react on the error() signal.
* @param enable true to enable auto error handling, false to disable
* @param parent the parent widget for the error dialogs, can be 0 for
* top-level
* @see autoErrorHandlingEnabled()
*/
void setAutoErrorHandlingEnabled( bool enable, QWidget *parent );
(the QWidget* would also allow to give a proper parent widget for the dialog box \
instead of the current activeWindow() hack)
/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h
<http://svn.reviewboard.kde.org/r/6004/#comment9991>
const QString &
- David
On 2010-11-30 20:57:03, Matthias Fuchs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6004/
> -----------------------------------------------------------
>
> (Updated 2010-11-30 20:57:03)
>
>
> Review request for kdelibs and David Faure.
>
>
> Summary
> -------
>
> Adds method to KBookmarkManager disable showing dialogs on errors.
> This way it is possible to deactivate those messages if KBoomarkManager is not run \
> in the gui thread. BUG:207592
>
>
> This addresses bug 207592.
> https://bugs.kde.org/show_bug.cgi?id=207592
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h 1202414
> /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc 1202414
>
> Diff: http://svn.reviewboard.kde.org/r/6004/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matthias
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6004/">http://svn.reviewboard.kde.org/r/6004/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6004/diff/4/?file=41984#file41984line111" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">111</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">setDialogsAllowed</span><span \
class="p">(</span><span class="n">bool</span> <span class="n">allowed</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would \
prefer if it was named like the similar method in KDirLister:
/**
* Check whether auto error handling is enabled.
* If enabled, it will show an error dialog to the user when an
* error occurs. It is turned on by default.
* @return true if auto error handling is enabled, false otherwise
* @see setAutoErrorHandlingEnabled()
*/
bool autoErrorHandlingEnabled() const;
/**
* Enable or disable auto error handling is enabled.
* If enabled, it will show an error dialog to the user when an
* error occurs. It is turned on by default.
* If disabled, the application should react on the error() signal.
* @param enable true to enable auto error handling, false to disable
* @param parent the parent widget for the error dialogs, can be 0 for
* top-level
* @see autoErrorHandlingEnabled()
*/
void setAutoErrorHandlingEnabled( bool enable, QWidget *parent );
(the QWidget* would also allow to give a proper parent widget for the dialog box \
instead of the current activeWindow() hack) </pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6004/diff/4/?file=41984#file41984line318" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Q_SIGNALS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">318</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">error</span><span class="p">(</span><span \
class="n">QString</span> <span class="n">errorMessage</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">const \
QString &</pre> </div>
<br />
<p>- David</p>
<br />
<p>On November 30th, 2010, 8:57 p.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated 2010-11-30 20:57:03</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds method to KBookmarkManager disable showing dialogs on errors. This \
way it is possible to deactivate those messages if KBoomarkManager is not run in the \
gui thread. BUG:207592</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=207592">207592</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h <span style="color: \
grey">(1202414)</span></li>
<li>/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc <span style="color: \
grey">(1202414)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6004/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic