From kde-core-devel Fri Dec 03 05:19:06 2010 From: Vishal Rao Date: Fri, 03 Dec 2010 05:19:06 +0000 To: kde-core-devel Subject: Potential issue in kshareddatacache.cpp checkin revision 1193778 Message-Id: X-MARC-Message: https://marc.info/?l=kde-core-devel&m=129139714220876 Hello, Sorry if this is spam/silly. I happened to notice this while browsing the 4.5.4 release announcement pages: unsigned KSharedDataCache::totalSize() const has added: if (lock.failed()) { return false; } Returning bool false for return type unsigned - is this a potential problem or do you check for MAX_UINT or whatever? Regards, Vishal -- "Thou shalt not follow the null pointer for at its end madness and chaos lie."