--===============6753845293090503647== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-11-29 00:08:22, Albert Astals Cid wrote: > > Why did you change the if/else logic? Also you added another kError whe= n there was an existing one already. > > = > > Also as commented on IRC maybe it would make sense to emit a signal to = warn whoever might be interested that an error happened I changed that to always have a useful debug output. The second one is ther= e to make it easier if there are bug reports, as it is hard to work with tr= anslated messages, especially if they are quite important. So not the whole= message is translated, probably I should us an error code there, as file.e= rrorString() is translated. - Matthias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/#review9034 ----------------------------------------------------------- On 2010-11-28 21:00:30, Matthias Fuchs wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6004/ > ----------------------------------------------------------- > = > (Updated 2010-11-28 21:00:30) > = > = > Review request for kdelibs and David Faure. > = > = > Summary > ------- > = > Adds method to KBookmarkManager disable showing dialogs on errors. > This way it is possible to deactivate those messages if KBoomarkManager i= s not run in the gui thread. > BUG:207592 > = > = > Diffs > ----- > = > /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h 1201809 = > /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc 1201809 = > = > Diff: http://svn.reviewboard.kde.org/r/6004/diff > = > = > Testing > ------- > = > = > Thanks, > = > Matthias > = > --===============6753845293090503647== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6004/ |
On November 29th, 2010, 12:08 a.m., Albert = Astals Cid wrote:
Why did y= ou change the if/else logic? Also you added another kError when there was a= n existing one already. Also as commented on IRC maybe it would make sense to emit a signal to warn= whoever might be interested that an error happened
I changed t= hat to always have a useful debug output. The second one is there to make i= t easier if there are bug reports, as it is hard to work with translated me= ssages, especially if they are quite important. So not the whole message is= translated, probably I should us an error code there, as file.errorString(= ) is translated.
- Matthias
On November 28th, 2010, 9 p.m., Matthias Fuchs wrote:
Review request for kdelibs and David Faure.
By Matthias Fuchs.
Updated 2010-11-28 21:00:30 Descripti= on
Diffs=
|