[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Merge changes from ffmpethumbnail projekt into
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2010-11-22 21:10:51
Message-ID: 20101122211051.11654.96840 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5937/#review8904
-----------------------------------------------------------
Wouldn't it be much simpler to use a scaled QPainter on the QImage to rende=
r the filmstrip holes at different sizes?
- Christoph
On 2010-11-22 20:16:46, Andreas Scherf wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5937/
> -----------------------------------------------------------
> =
> (Updated 2010-11-22 20:16:46)
> =
> =
> Review request for kdelibs.
> =
> =
> Summary
> -------
> =
> + Some type changes (uinXX to quintXX), some code cleanup and some compil=
e fixes.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdemultimedia/CMakeLists.txt 1199813 =
> trunk/KDE/kdemultimedia/cmake/modules/FindFFMPEG.cmake PRE-CREATION =
> trunk/KDE/kdemultimedia/ffmpegthumbs/CMakeLists.txt 1199813 =
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/ChangeLog 119981=
3 =
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstrip.h PRE-=
CREATION =
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstripfilter.=
cpp 1199813 =
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.h 1=
199813 =
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.cpp=
1199813 =
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videoframe.h 119=
9813 =
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailer=
.h 1199813 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5937/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Andreas
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5937/">http://svn.reviewboard.kde.org/r/5937/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wouldn't it be much \
simpler to use a scaled QPainter on the QImage to render the filmstrip holes at \
different sizes?</pre> <br />
<p>- Christoph</p>
<br />
<p>On November 22nd, 2010, 8:16 p.m., Andreas Scherf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Andreas Scherf.</div>
<p style="color: grey;"><i>Updated 2010-11-22 20:16:46</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">+ Some type changes (uinXX to quintXX), some code cleanup and some \
compile fixes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdemultimedia/CMakeLists.txt <span style="color: \
grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/cmake/modules/FindFFMPEG.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/CMakeLists.txt <span style="color: \
grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/ChangeLog <span \
style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstrip.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstripfilter.cpp <span \
style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.h <span \
style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.cpp <span \
style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videoframe.h <span \
style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailer.h <span \
style="color: grey">(1199813)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5937/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic