'Re: Review Request: Add isReleased() method to StorageDrive interface'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add isReleased() method to StorageDrive interface
From:       "Jacopo De Simoi" <wilderkde () gmail ! com>
Date:       2010-11-08 11:10:45
Message-ID: 20101108111045.24344.28614 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5770/
-----------------------------------------------------------

(Updated 2010-11-08 11:10:44.918200)


Review request for kdelibs and Kevin Ottens.


Changes
-------

+ Fix WS
+ Added the released Q_PROPERTY
+ Fixed listFromQuery

Waiting for API review by some native speaker to commit


Summary
-------

This patch adds a isReleased() method in the StorageDrive interface. =

The usecase for this are applications that need to know if it is possible t=
o safely unplug a device by checking the isReleased() property on the paren=
t drive. =



Diffs (updated)
-----

  trunk/KDE/kdelibs/solid/solid/storagedrive.h 1193078 =

  trunk/KDE/kdelibs/solid/solid/storagedrive.cpp 1193078 =


Diff: http://svn.reviewboard.kde.org/r/5770/diff


Testing
-------


Thanks,

Jacopo


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5770/">http://svn.reviewboard.kde.org/r/5770/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and Kevin Ottens.</div>
<div>By Jacopo De Simoi.</div>


<p style="color: grey;"><i>Updated 2010-11-08 11:10:44.918200</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">+ Fix WS + Added the released Q_PROPERTY
+ Fixed listFromQuery

Waiting for API review by some native speaker to commit</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a isReleased() method in the StorageDrive interface.  \
The usecase for this are applications that need to know if it is possible to safely \
unplug a device by checking the isReleased() property on the parent drive. </pre>  \
</td>  </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdelibs/solid/solid/storagedrive.h <span style="color: \
grey">(1193078)</span></li>

 <li>trunk/KDE/kdelibs/solid/solid/storagedrive.cpp <span style="color: \
grey">(1193078)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5770/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic