[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Four simple patches for kdecore
From: "Jaime Torres" <jtamate () gmail ! com>
Date: 2010-11-07 14:17:29
Message-ID: 20101107141729.21520.96137 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5775/
-----------------------------------------------------------
(Updated 2010-11-07 14:17:29.120532)
Review request for kdelibs.
Changes
-------
Changed the comment. =
Summary
-------
As I do not know if that kind of patches are allowed in the freeze period, =
I ask for them together. I'll submit them individually.
1. ktimezone. Include a comment with the real use of refCount.
2. klocale_kde. From 469 queries to paths.end() to 1 (from 0.01% to 0% in c=
allgrind)
3. netsupp. Remove a memory leak.
4. ksharedDataCache. Change the obsolete usleep (since 2001 or before) to n=
anosleep.
Diffs (updated)
-----
/trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp 1193582 =
/trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp 1193582 =
/trunk/KDE/kdelibs/kdecore/network/netsupp.cpp 1193582 =
/trunk/KDE/kdelibs/kdecore/util/kshareddatacache.cpp 1193582 =
Diff: http://svn.reviewboard.kde.org/r/5775/diff
Testing
-------
No regressions in the unit tests.
Working with them.
Thanks,
Jaime
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5775/">http://svn.reviewboard.kde.org/r/5775/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres.</div>
<p style="color: grey;"><i>Updated 2010-11-07 14:17:29.120532</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed the comment. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As I do not know if that kind of patches are allowed in the freeze \
period, I ask for them together. I'll submit them individually.
1. ktimezone. Include a comment with the real use of refCount.
2. klocale_kde. From 469 queries to paths.end() to 1 (from 0.01% to 0% in callgrind)
3. netsupp. Remove a memory leak.
4. ksharedDataCache. Change the obsolete usleep (since 2001 or before) to \
nanosleep.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No regressions in the unit tests. Working with them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp <span style="color: \
grey">(1193582)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp <span style="color: \
grey">(1193582)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/network/netsupp.cpp <span style="color: \
grey">(1193582)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/util/kshareddatacache.cpp <span style="color: \
grey">(1193582)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5775/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic