[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: A Facet and search GUI API for Nepomuk
From: "Sebastian Trueg" <trueg () kde ! org>
Date: 2010-10-25 19:13:25
Message-ID: 20101025191325.30100.46935 () vidsolbach ! de
[Download RAW message or body]
> On 2010-10-25 18:52:33, Christoph Feck wrote:
> > It does not compile.
> > =
> > /local/svn/kde/trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp: In func=
tion 'Soprano::LiteralValue<unnamed>::createLiteral(const QString&, bool)':
> > /local/svn/kde/trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp:148:24: =
error: conversion from 'QStringBuilder<QString, char>' to non-scalar type '=
Soprano::LiteralValue' requested
> > /local/svn/kde/trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp:151:5: e=
rror: control reaches end of non-void function
Oho, that is not part of this review. It is the QString % operator that I c=
ommited by accident a few minutes later. Consider it removed. :)
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5671/#review8347
-----------------------------------------------------------
On 2010-10-25 12:54:19, Sebastian Trueg wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5671/
> -----------------------------------------------------------
> =
> (Updated 2010-10-25 12:54:19)
> =
> =
> Review request for kdelibs and Vishesh Handa.
> =
> =
> Summary
> -------
> =
> I have been struggling with creating a good facet API for a long time now=
. I finally reached a point where I am happy with the result. IMHO this is =
essential enough to get into kdelibs/nepomuk. The first usage will obviousl=
y be Dolphin, closely followed by the file dialog. All in all this will mak=
e it so much simpler to provide Nepomuk powered search capabilities in appl=
ications.
> Anyway, this review request is intended for an API review before I commit.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdelibs/includes/CMakeLists.txt 1187872 =
> trunk/KDE/kdelibs/includes/Nepomuk/Utils/DynamicResourceFacet PRE-CREAT=
ION =
> trunk/KDE/kdelibs/includes/Nepomuk/Utils/Facet PRE-CREATION =
> trunk/KDE/kdelibs/includes/Nepomuk/Utils/FacetWidget PRE-CREATION =
> trunk/KDE/kdelibs/includes/Nepomuk/Utils/ProxyFacet PRE-CREATION =
> trunk/KDE/kdelibs/includes/Nepomuk/Utils/ResourceModel PRE-CREATION =
> trunk/KDE/kdelibs/includes/Nepomuk/Utils/SearchWidget PRE-CREATION =
> trunk/KDE/kdelibs/includes/Nepomuk/Utils/SimpleFacet PRE-CREATION =
> trunk/KDE/kdelibs/includes/Nepomuk/Utils/SimpleResourceModel PRE-CREATI=
ON =
> trunk/KDE/kdelibs/nepomuk/Mainpage.dox 1187872 =
> trunk/KDE/kdelibs/nepomuk/utils/CMakeLists.txt 1187872 =
> trunk/KDE/kdelibs/nepomuk/utils/datefacet.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/datefacet.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/daterange.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/daterange.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/daterangeselectionwidget.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/daterangeselectionwidget.cpp PRE-CREATI=
ON =
> trunk/KDE/kdelibs/nepomuk/utils/daterangeselectionwidget.ui PRE-CREATIO=
N =
> trunk/KDE/kdelibs/nepomuk/utils/dynamicresourcefacet.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/dynamicresourcefacet.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/facet.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/facet.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/facetdelegate.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/facetdelegate.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/facetfiltermodel.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/facetfiltermodel.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/facetmodel.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/facetmodel.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/facetwidget.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/facetwidget.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/proxyfacet.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/proxyfacet.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/resourcemodel.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/resourcemodel.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/searchlineedit.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/searchlineedit.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/searchwidget.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/searchwidget.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/searchwidget_p.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/simplefacet.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/simplefacet.cpp PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/simpleresourcemodel.h PRE-CREATION =
> trunk/KDE/kdelibs/nepomuk/utils/simpleresourcemodel.cpp PRE-CREATION =
> =
> Diff: http://svn.reviewboard.kde.org/r/5671/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Sebastian
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5671/">http://svn.reviewboard.kde.org/r/5671/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 25th, 2010, 6:52 p.m., <b>Christoph \
Feck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It does not compile.
/local/svn/kde/trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp: In function \
'Soprano::LiteralValue<unnamed>::createLiteral(const QString&, \
bool)':
/local/svn/kde/trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp:148:24: error: \
conversion from 'QStringBuilder<QString, char>' to non-scalar type \
'Soprano::LiteralValue' requested
/local/svn/kde/trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp:151:5: error: control \
reaches end of non-void function</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oho, that is not part of \
this review. It is the QString % operator that I commited by accident a few minutes \
later. Consider it removed. :)</pre> <br />
<p>- Sebastian</p>
<br />
<p>On October 25th, 2010, 12:54 p.m., Sebastian Trueg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Vishesh Handa.</div>
<div>By Sebastian Trueg.</div>
<p style="color: grey;"><i>Updated 2010-10-25 12:54:19</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have been struggling with creating a good facet API for a long time \
now. I finally reached a point where I am happy with the result. IMHO this is \
essential enough to get into kdelibs/nepomuk. The first usage will obviously be \
Dolphin, closely followed by the file dialog. All in all this will make it so much \
simpler to provide Nepomuk powered search capabilities in applications. Anyway, this \
review request is intended for an API review before I commit.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/includes/CMakeLists.txt <span style="color: \
grey">(1187872)</span></li>
<li>trunk/KDE/kdelibs/includes/Nepomuk/Utils/DynamicResourceFacet <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/includes/Nepomuk/Utils/Facet <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/includes/Nepomuk/Utils/FacetWidget <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/includes/Nepomuk/Utils/ProxyFacet <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/includes/Nepomuk/Utils/ResourceModel <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/includes/Nepomuk/Utils/SearchWidget <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/includes/Nepomuk/Utils/SimpleFacet <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/includes/Nepomuk/Utils/SimpleResourceModel <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/Mainpage.dox <span style="color: \
grey">(1187872)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/CMakeLists.txt <span style="color: \
grey">(1187872)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/datefacet.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/datefacet.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/daterange.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/daterange.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/daterangeselectionwidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/daterangeselectionwidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/daterangeselectionwidget.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/dynamicresourcefacet.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/dynamicresourcefacet.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/facet.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/facet.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/facetdelegate.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/facetdelegate.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/facetfiltermodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/facetfiltermodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/facetmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/facetmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/facetwidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/facetwidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/proxyfacet.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/proxyfacet.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/resourcemodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/resourcemodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/searchlineedit.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/searchlineedit.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/searchwidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/searchwidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/searchwidget_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/simplefacet.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/simplefacet.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/simpleresourcemodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/nepomuk/utils/simpleresourcemodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5671/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic