[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: updated kded4 man page
From: "Jaime Torres" <jtamate () gmail ! com>
Date: 2010-10-11 12:11:36
Message-ID: 20101011121136.7868.25767 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5557/
-----------------------------------------------------------
(Updated 2010-10-11 12:11:36.026257)
Review request for kdelibs.
Changes
-------
Done David suggestions, after a bugday.
Also introduced how to enable/disable the init kded4 modules.
Is it ok that way of describing the menus?
If yes, probably it is ready for shipping.
Summary
-------
Three questions:
* Is it wrote in correct English?
* Is it ok to list the modules in that way and in that page?
* In the KCM module Service Manager (from where I've copied the names and \
descriptions) there are 5 descriptions missing (also in the man \
page):
* KDED Subversion module
* KDED module for screen-managment
* Keyboard Daemon
* Display Managment change monitor
* K Remote Control Daemon
Please, non trivial descriptions?
This addresses bug 242582.
https://bugs.kde.org/show_bug.cgi?id=242582
Diffs (updated)
-----
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook 1183954
Diff: http://svn.reviewboard.kde.org/r/5557/diff
Testing
-------
The man page is more complete, and now can search for out of space
Thanks,
Jaime
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5557/">http://svn.reviewboard.kde.org/r/5557/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres.</div>
<p style="color: grey;"><i>Updated 2010-10-11 12:11:36.026257</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Done David suggestions, after a bugday. Also introduced how to \
enable/disable the init kded4 modules. Is it ok that way of describing the menus?
If yes, probably it is ready for shipping.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Three questions:
* Is it wrote in correct English?
* Is it ok to list the modules in that way and in that page?
* In the KCM module Service Manager (from where I've copied the names and \
descriptions) there are 5 descriptions missing (also in the man \
page):
* KDED Subversion module
* KDED module for screen-managment
* Keyboard Daemon
* Display Managment change monitor
* K Remote Control Daemon
Please, non trivial descriptions?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The man page is more complete, and now can search for out of space</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=242582">242582</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook <span style="color: \
grey">(1183954)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5557/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic