[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: introduce the class Configuration Compile
From: "Jaime Torres" <jtamate () gmail ! com>
Date: 2010-10-08 16:44:39
Message-ID: 20101008164439.11552.13125 () vidsolbach ! de
[Download RAW message or body]
> On 2010-10-08 14:48:38, Pino Toscano wrote:
> > Did you test a compilation and run of the kconfig_compiler unit test in \
> > kdeui/tests?
Now yes.
Start 34: kconfigcompiler_test
34/34 Test #34: kconfigcompiler_test ............... Passed 1.18 sec
By the way, why the config_compiler unit tests are in kdeui? Should not they be in \
kdecore?
> On 2010-10-08 14:48:38, Pino Toscano wrote:
> > /trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp, line 110
> > <http://svn.reviewboard.kde.org/r/5479/diff/2/?file=38743#file38743line110>
> >
> > Not sure which strategy you want to do for supporting other languages than C++ \
> > (ie add the various formats in this .cpp or split the languages each in an own \
> > kconfig_compiler_<language>.cpp); in case of the latter, you could start directly \
> > in this step to move the definition of the CfgConfig class in an own .h file.
I will split the languages each in an own kconfig_compiler_<language>.cpp.
As there are currently only two fully implemented (c++ and ruby), and ruby is in \
kdebindings. I want to do this step the latest one.
- Jaime
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5479/#review8042
-----------------------------------------------------------
On 2010-09-30 17:35:38, Jaime Torres wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5479/
> -----------------------------------------------------------
>
> (Updated 2010-09-30 17:35:38)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Just create the class CfgConfig, grouping all the configuration items in one place.
> Also, use an instance where any of the configuration values is needed.
>
> Next patch: make independent the input parser and the output to c++ language.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp 1180729
>
> Diff: http://svn.reviewboard.kde.org/r/5479/diff
>
>
> Testing
> -------
>
> tested time ago in cygwin.
> tested few minutes ago recompiling akregator.
>
>
> Thanks,
>
> Jaime
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5479/">http://svn.reviewboard.kde.org/r/5479/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 8th, 2010, 2:48 p.m., <b>Pino \
Toscano</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Did you test a compilation and run of the kconfig_compiler unit test in \
kdeui/tests?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now yes. Start 34: \
kconfigcompiler_test 34/34 Test #34: kconfigcompiler_test ............... Passed \
1.18 sec
By the way, why the config_compiler unit tests are in kdeui? Should not they be in \
kdecore?</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 8th, 2010, 2:48 p.m., <b>Pino \
Toscano</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5479/diff/2/?file=38743#file38743line110" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">106</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">class</span> <span class="nc">CfgConfig</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure which strategy \
you want to do for supporting other languages than C++ (ie add the various formats in \
this .cpp or split the languages each in an own \
kconfig_compiler_<language>.cpp); in case of the latter, you could start \
directly in this step to move the definition of the CfgConfig class in an own .h \
file.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will \
split the languages each in an own kconfig_compiler_<language>.cpp. As there \
are currently only two fully implemented (c++ and ruby), and ruby is in kdebindings. \
I want to do this step the latest one. </pre>
<br />
<p>- Jaime</p>
<br />
<p>On September 30th, 2010, 5:35 p.m., Jaime Torres wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres.</div>
<p style="color: grey;"><i>Updated 2010-09-30 17:35:38</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Just create the class CfgConfig, grouping all the configuration items in \
one place. Also, use an instance where any of the configuration values is needed.
Next patch: make independent the input parser and the output to c++ language.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested time ago in cygwin. tested few minutes ago recompiling \
akregator.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp <span \
style="color: grey">(1180729)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5479/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic