[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Move CursorTheme KCM from "Input Devices/Mouse" to
From: "Ben Cooksley" <sourtooth () gmail ! com>
Date: 2010-09-29 1:22:08
Message-ID: 20100929012208.2464.19475 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5468/#review7865
-----------------------------------------------------------
Ship it!
Diff looks fine to me. Please commit.
- Ben
On 2010-09-29 00:32:12, Christoph Feck wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5468/
> -----------------------------------------------------------
> =
> (Updated 2010-09-29 00:32:12)
> =
> =
> Review request for kdelibs, Fredrik H=C3=B6glund and Ben Cooksley.
> =
> =
> Summary
> -------
> =
> As discussed with Ben Cooksley, split the CursorTheme KCM and move it to =
the Workspace Appearance category in System Settings.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/kcontrol/input/CMakeLists.txt 1180776 =
> /trunk/KDE/kdebase/workspace/kcontrol/input/cursortheme.desktop PRE-CRE=
ATION =
> /trunk/KDE/kdebase/workspace/kcontrol/input/kcmcursortheme.h PRE-CREATI=
ON =
> /trunk/KDE/kdebase/workspace/kcontrol/input/kcmcursortheme.cpp PRE-CREA=
TION =
> /trunk/KDE/kdebase/workspace/kcontrol/input/mouse.h 1180776 =
> /trunk/KDE/kdebase/workspace/kcontrol/input/mouse.cpp 1180776 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5468/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Christoph
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5468/">http://svn.reviewboard.kde.org/r/5468/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Diff looks fine to me. \
Please commit.</pre> <br />
<p>- Ben</p>
<br />
<p>On September 29th, 2010, 12:32 a.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Fredrik Höglund and Ben Cooksley.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated 2010-09-29 00:32:12</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed with Ben Cooksley, split the CursorTheme KCM and move it to \
the Workspace Appearance category in System Settings.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kcontrol/input/CMakeLists.txt <span style="color: \
grey">(1180776)</span></li>
<li>/trunk/KDE/kdebase/workspace/kcontrol/input/cursortheme.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/kcontrol/input/kcmcursortheme.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/kcontrol/input/kcmcursortheme.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/kcontrol/input/mouse.h <span style="color: \
grey">(1180776)</span></li>
<li>/trunk/KDE/kdebase/workspace/kcontrol/input/mouse.cpp <span style="color: \
grey">(1180776)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5468/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic