[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: create a menu entry in the help menu to enable
From: "Jaime Torres" <jtamate () gmail ! com>
Date: 2010-09-29 17:17:09
Message-ID: 20100929171709.20150.35406 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5469/
-----------------------------------------------------------
(Updated 2010-09-29 17:17:09.342514)
Review request for kdelibs.
Changes
-------
Changed the menu entry to follow the original "Do not ask again", instead of "Do Not \
Ask Again". Implemented the messagebox. Please review the message, my spanglish \
lately is more spanish than english.
Summary
-------
Create a menu entry in the help menu to enable again all the "do not ask again" \
messagebox for that application. Probably there is a better description for the menu \
entry (but I can not find it). Also, the icon for the entry is missing (or does it \
need an icon?)
I hope this is Binary Compatible.
Of course, when I'll commit, I'll remove all the trailing spaces (How can I see them \
before doing a post-review?).
This addresses bug 190238.
https://bugs.kde.org/show_bug.cgi?id=190238
Diffs (updated)
-----
/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.h 1180729
/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.cpp 1180729
/trunk/KDE/kdelibs/kdeui/xmlgui/ui_standards.rc 1180729
/trunk/KDE/kdelibs/kdeui/actions/kstandardaction_p.h 1180729
/trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h 1180729
/trunk/KDE/kdelibs/kdeui/actions/kstandardaction.cpp 1180729
Diff: http://svn.reviewboard.kde.org/r/5469/diff
Testing
-------
konsole ask again "Do you have multiplies tabs, do you want to close,....."
Thanks,
Jaime
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5469/">http://svn.reviewboard.kde.org/r/5469/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres.</div>
<p style="color: grey;"><i>Updated 2010-09-29 17:17:09.342514</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed the menu entry to follow the original "Do not ask \
again", instead of "Do Not Ask Again". Implemented the messagebox. \
Please review the message, my spanglish lately is more spanish than english. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Create a menu entry in the help menu to enable again all the "do \
not ask again" messagebox for that application. Probably there is a better \
description for the menu entry (but I can not find it). Also, the icon for the entry \
is missing (or does it need an icon?)
I hope this is Binary Compatible.
Of course, when I'll commit, I'll remove all the trailing spaces (How can I \
see them before doing a post-review?).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">konsole ask again "Do you have multiplies tabs, do you want to \
close,....." </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=190238">190238</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.h <span style="color: \
grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.cpp <span style="color: \
grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/xmlgui/ui_standards.rc <span style="color: \
grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/actions/kstandardaction_p.h <span style="color: \
grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h <span style="color: \
grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/actions/kstandardaction.cpp <span style="color: \
grey">(1180729)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5469/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic