'Review Request: fix bug 193364 (I can use again k3b)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: fix bug 193364 (I can use again k3b)
From:       "Jaime Torres" <jtamate () gmail ! com>
Date:       2010-09-25 8:22:18
Message-ID: 20100925082218.23701.38339 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5447/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

It crashed because there was a kdirlister without jobs. Tracing the file with a lot \
of kdebug... I found that the kdirlister without jobs has no jobs for any url \
(totally completed), but was not removed from the list of listeners. Removing it from \
the list, the bug is gone.


This addresses bug 193364.
    https://bugs.kde.org/show_bug.cgi?id=193364


Diffs
-----

  /trunk/KDE/kdelibs/kio/kio/kdirlister.cpp 1179247 

Diff: http://svn.reviewboard.kde.org/r/5447/diff


Testing
-------

I was able to reproduce the bug 193364 allways, making k3b unusable for me. 
(I do not know why I was able to do it everytime). I suspect it could be because I \
changed fstab to enable the automount of /tmp as tmpfs. With the patch, I can use k3b \
again.


Thanks,

Jaime


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5447/">http://svn.reviewboard.kde.org/r/5447/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Jaime Torres.</div>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It crashed because there was a kdirlister without jobs. Tracing the file \
with a lot of kdebug... I found that the kdirlister without jobs has no jobs for any \
url (totally completed), but was not removed from the list of listeners. Removing it \
from the list, the bug is gone. </pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I was able to reproduce the bug 193364 allways, making k3b unusable for \
me.  (I do not know why I was able to do it everytime). I suspect it could be because \
I changed fstab to enable the automount of /tmp as tmpfs. With the patch, I can use \
k3b again. </pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=193364">193364</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdelibs/kio/kio/kdirlister.cpp <span style="color: \
grey">(1179247)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5447/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic