From kde-core-devel Tue Sep 21 17:38:14 2010 From: "Guy Maurel" Date: Tue, 21 Sep 2010 17:38:14 +0000 To: kde-core-devel Subject: Re: Review Request: Attica will not be found if installed under Message-Id: <20100921173814.25572.73701 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=128509073115105 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4151862267599406876==" --===============4151862267599406876== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-09-17 18:52:17, Alexander Neundorf wrote: > > /usr/local is part of the default search directories, so it should be f= ound if installed there. > > I just tested this here locally and it works for me. > > = > > If it is not found when installed in /usr/local/, then we have to check= what is going wrong there. > > = > > Alex > = > Guy Maurel wrote: > mmmh! > I found at http://www.kitware.com/news/home/browse/168: > "FIND_LIBRARY and FIND_PATH now look in CMAKE_LIBRARY_PATH and CMAKE_= INCLUDE_PATH environment variables in addition to and before the PATH envir= onment variable. " > It is what I need, but nothing about a default value for CMAKE_LIBRAR= Y_PATH and CMAKE_INCLUDE_PATH > Is it something the user *has* to do itself before running? Thanks to Alex for the discussion and your questions/helps. The CMAKE_INCLUDE_PATH give the order to search for: *First* at /usr/local *then* at /usr This is done (I think) to give a priority to the packages one have self ins= talled. = At the FindLibAttica.cmake (and other more) there is some lines of code suc= h: IF (NOT WIN32) # use pkg-config to get the directories and then use these values # in the FIND_PATH() and FIND_LIBRARY() calls FIND_PACKAGE(PkgConfig) PKG_CHECK_MODULES(PC_LIBATTICA QUIET libattica) SET(LIBATTICA_DEFINITIONS ${PC_ATTICA_CFLAGS_OTHER}) ENDIF (NOT WIN32) I am using ArchLinux and the pacman-command installs (implicitly) some pack= ages I havn't take care. One of them was "attica", installed at /usr . The search order is changed. The cmake works correctly with FindLibAttica.cmake and told me: /usr/includ= e . *NOW* I would like to ask: What is the reason/strategy of changing the sear= ch order in this way? *MY* problem is now solved. Thanks - Guy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5375/#review7673 ----------------------------------------------------------- On 2010-09-17 18:08:15, Guy Maurel wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5375/ > ----------------------------------------------------------- > = > (Updated 2010-09-17 18:08:15) > = > = > Review request for kdelibs. > = > = > Summary > ------- > = > Some of the cmake/modules/Findxxx.cmake files have extended the search to= the directory INCLUDE_INSTALL_DIR > It is usefull to find the version on had installed just before. Many defa= ult installations are /usr/local/ > = > My proposal is to do the same with Attica. > = > = > Diffs > ----- > = > /trunk/KDE/kdelibs/cmake/modules/FindLibAttica.cmake 1175716 = > = > Diff: http://svn.reviewboard.kde.org/r/5375/diff > = > = > Testing > ------- > = > = > Thanks, > = > Guy > = > --===============4151862267599406876== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5375/

On September 17th, 2010, 6:52 p.m., Alexand= er Neundorf wrote:

/usr/loca=
l is part of the default search directories, so it should be found if insta=
lled there.
I just tested this here locally and it works for me.

If it is not found when installed in /usr/local/, then we have to check wha=
t is going wrong there.

Alex

On September 19th, 2010, 5:08 p.m., Guy Maurel wrote:

mmmh!
I found at http://www.kitware.com/news/home/browse/168:
"FIND_LIBRARY and FIND_PATH now look in CMAKE_LIBRARY_PATH and CMAKE_I=
NCLUDE_PATH environment variables in addition to and before the PATH enviro=
nment variable. "
It is what I need, but nothing about a default value for CMAKE_LIBRARY_PATH=
 and CMAKE_INCLUDE_PATH
Is it something the user *has* to do itself before running?
Thanks to A=
lex for the discussion and your questions/helps.

The CMAKE_INCLUDE_PATH give the order to search for:
*First* at /usr/local
*then*  at /usr
This is done (I think) to give a priority to the packages one have self ins=
talled. =


At the FindLibAttica.cmake (and other more) there is some lines of code suc=
h:
IF (NOT WIN32)
   # use pkg-config to get the directories and then use these values
   # in the FIND_PATH() and FIND_LIBRARY() calls
   FIND_PACKAGE(PkgConfig)
   PKG_CHECK_MODULES(PC_LIBATTICA QUIET libattica)
   SET(LIBATTICA_DEFINITIONS ${PC_ATTICA_CFLAGS_OTHER})
ENDIF (NOT WIN32)

I am using ArchLinux and the pacman-command installs (implicitly) some pack=
ages I havn't take care.
One of them was "attica", installed at /usr . The search order is=
 changed.
The cmake works correctly with FindLibAttica.cmake and told me: /usr/includ=
e .

*NOW* I would like to ask: What is the reason/strategy of changing the sear=
ch order in this way?

*MY* problem is now solved.
Thanks

- Guy


On September 17th, 2010, 6:08 p.m., Guy Maurel wrote:

Review request for kdelibs.
By Guy Maurel.

Updated 2010-09-17 18:08:15

Descripti= on 

Some of the cmake/modules/Findxxx.cmake files have extended =
the search to the directory INCLUDE_INSTALL_DIR
It is usefull to find the version on had installed just before. Many defaul=
t installations are /usr/local/

My proposal is to do the same with Attica.

Diffs=

  • /trunk/KDE/kdelibs/cmake/modules/FindLibAttica.cmake (1175716)

View Diff
--===============4151862267599406876==--