[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add missing title to sonnet KCM (kcmshell4
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2010-09-20 18:50:20
Message-ID: 20100920185020.11343.67537 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5381/#review7696
-----------------------------------------------------------
Ship it!
Makes sense.
- Albert
On 2010-09-18 20:31:48, Burkhard L=C3=BCck wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5381/
> -----------------------------------------------------------
> =
> (Updated 2010-09-18 20:31:48)
> =
> =
> Review request for kdelibs.
> =
> =
> Summary
> -------
> =
> The sonnet KCM (kcmshell4 spellchecking) has an edit field and a listbox =
with actions to add, remove, move up and down items, but it is not obvious =
for Joe User what items are handled here. Adding a title "Ignored Words" to=
this "KEditListBox" explains the use case of this gui element.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdelibs/kdeui/sonnet/configui.ui 1175322 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5381/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Burkhard
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5381/">http://svn.reviewboard.kde.org/r/5381/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes sense.</pre> <br \
/>
<p>- Albert</p>
<br />
<p>On September 18th, 2010, 8:31 p.m., Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated 2010-09-18 20:31:48</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The sonnet KCM (kcmshell4 spellchecking) has an edit field and a listbox \
with actions to add, remove, move up and down items, but it is not obvious for Joe \
User what items are handled here. Adding a title "Ignored Words" to this \
"KEditListBox" explains the use case of this gui element.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdeui/sonnet/configui.ui <span style="color: \
grey">(1175322)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5381/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic