[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Cleanup KLed
From: "Pedro Lopez-Cabanillas" <pedro.lopez.cabanillas () gmail ! com>
Date: 2010-09-17 9:02:40
Message-ID: 20100917090240.4280.85291 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5369/#review7653
-----------------------------------------------------------
KMid uses rectangular KLeds in its Rhythm view. The problem with your patch is that \
makes the leds always squared, not rectangular. Please, enable again different \
dimensions (width != height) when the shape is rectangular. Other than that, \
excellent work!
- Pedro
On 2010-09-17 05:18:58, Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5369/
> -----------------------------------------------------------
>
> (Updated 2010-09-17 05:18:58)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> * massive code reduction by using Qt gradients
> * fix background, now uses transparency
> * fix cache not updated on look changes
> * fix cropped appearance
> * simplify cachedPixmap handling
> * use SmallIconSize as sizeHint
> * remove "builtin" benchmark
>
> I would like to get feedback on the changed rendering of rectangular LEDs.
>
>
> This addresses bug 98719.
> https://bugs.kde.org/show_bug.cgi?id=98719
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdeui/widgets/kled.h 1176221
> /trunk/KDE/kdelibs/kdeui/widgets/kled.cpp 1176221
>
> Diff: http://svn.reviewboard.kde.org/r/5369/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> OLD appearance
> http://svn.reviewboard.kde.org/r/5369/s/505/
> NEW appearance
> http://svn.reviewboard.kde.org/r/5369/s/506/
> r2 appearance
> http://svn.reviewboard.kde.org/r/5369/s/507/
>
>
> Thanks,
>
> Christoph
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5369/">http://svn.reviewboard.kde.org/r/5369/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KMid uses rectangular \
KLeds in its Rhythm view. The problem with your patch is that makes the leds always \
squared, not rectangular. Please, enable again different dimensions (width != height) \
when the shape is rectangular. Other than that, excellent work!</pre> <br />
<p>- Pedro</p>
<br />
<p>On September 17th, 2010, 5:18 a.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated 2010-09-17 05:18:58</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* massive code reduction by using Qt gradients
* fix background, now uses transparency
* fix cache not updated on look changes
* fix cropped appearance
* simplify cachedPixmap handling
* use SmallIconSize as sizeHint
* remove "builtin" benchmark
I would like to get feedback on the changed rendering of rectangular LEDs.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=98719">98719</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdeui/widgets/kled.h <span style="color: \
grey">(1176221)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kled.cpp <span style="color: \
grey">(1176221)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5369/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5369/s/505/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/17/snapshot-16_400x100.png" \
style="border: 1px black solid;" alt="OLD appearance" /></a>
<a href="http://svn.reviewboard.kde.org/r/5369/s/506/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/17/snapshot-15_400x100.png" \
style="border: 1px black solid;" alt="NEW appearance" /></a>
<a href="http://svn.reviewboard.kde.org/r/5369/s/507/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/17/snapshot-17_400x100.png" \
style="border: 1px black solid;" alt="r2 appearance" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic