[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Cleanup KLed
From: "Todd" <toddrme2178 () gmail ! com>
Date: 2010-09-17 2:28:17
Message-ID: 20100917022817.30296.98641 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5369/#review7647
-----------------------------------------------------------
Mostly it looks good, a lot better than it was, but I have a some suggestions:
* The black on and off states are identical as far as I can see
* The edges of the "raised" version do not look very raised. I would either get rid \
of it or give it a gradient like in the sunken version.
* If possible, I would not have the gradient at 45 degrees like it is now, I would \
have it a bit closer to horizontal or vertical. Having it at an angle that is +/-45 \
degrees looks artificial to me,the chance of a light source really being at that \
angle is slim. I also don't like having the light of the gradient in the sunken \
version right on the corner, which this would fix.
* I would make the white just a little off-white. Once again it looks too perfect, \
which looks artificial to me.
* If possible, it would be nice if the borders had a slight tint from the LED color \
when in the on state (but not the off state), to make it look like light from the LED \
is falling on the border.
* I would make the blue on state a lighter shade, it is not bright enough in my \
opinion. I would also make the off state a bit brighter, so it is easier to tell \
apart from black's off state.
* I would make the edges a bit thicker in the large versions, at least for the sunken \
and raised versions. They seem too small relative to the size of the button to me.
- Todd
On 2010-09-17 02:04:09, Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5369/
> -----------------------------------------------------------
>
> (Updated 2010-09-17 02:04:09)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> * massive code reduction by using Qt gradients
> * fix background, now uses transparency
> * fix cache not updated on look changes
> * fix cropped appearance
> * simplify cachedPixmap handling
> * use SmallIconSize as sizeHint
> * remove "builtin" benchmark
>
> I would like to get feedback on the changed rendering of rectangular LEDs.
>
>
> This addresses bug 98719.
> https://bugs.kde.org/show_bug.cgi?id=98719
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdeui/widgets/kled.h 1176162
> /trunk/KDE/kdelibs/kdeui/widgets/kled.cpp 1176162
>
> Diff: http://svn.reviewboard.kde.org/r/5369/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> OLD appearance
> http://svn.reviewboard.kde.org/r/5369/s/505/
> NEW appearance
> http://svn.reviewboard.kde.org/r/5369/s/506/
>
>
> Thanks,
>
> Christoph
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5369/">http://svn.reviewboard.kde.org/r/5369/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mostly it looks good, a \
lot better than it was, but I have a some suggestions:
* The black on and off states are identical as far as I can see
* The edges of the "raised" version do not look very raised. I would \
either get rid of it or give it a gradient like in the sunken \
version.
* If possible, I would not have the gradient at 45 degrees like it is now, I would \
have it a bit closer to horizontal or vertical. Having it at an angle that is +/-45 \
degrees looks artificial to me,the chance of a light source really being at that \
angle is slim. I also don't like having the light of the gradient in the sunken \
version right on the corner, which this would fix.
* I would make the white just a little off-white. Once again it looks too perfect, \
which looks artificial to me.
* If possible, it would be nice if the borders had a slight tint from the LED color \
when in the on state (but not the off state), to make it look like light from the LED \
is falling on the border.
* I would make the blue on state a lighter shade, it is not bright enough in my \
opinion. I would also make the off state a bit brighter, so it is easier to tell \
apart from black's off state.
* I would make the edges a bit thicker in the large versions, at least for the sunken \
and raised versions. They seem too small relative to the size of the button to \
me.</pre> <br />
<p>- Todd</p>
<br />
<p>On September 17th, 2010, 2:04 a.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated 2010-09-17 02:04:09</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* massive code reduction by using Qt gradients
* fix background, now uses transparency
* fix cache not updated on look changes
* fix cropped appearance
* simplify cachedPixmap handling
* use SmallIconSize as sizeHint
* remove "builtin" benchmark
I would like to get feedback on the changed rendering of rectangular LEDs.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=98719">98719</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdeui/widgets/kled.h <span style="color: \
grey">(1176162)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kled.cpp <span style="color: \
grey">(1176162)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5369/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5369/s/505/"><img \
src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" alt="OLD \
appearance" /></a>
<a href="http://svn.reviewboard.kde.org/r/5369/s/506/"><img \
src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" alt="NEW \
appearance" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic