[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Fix i18n regression
From:       David Faure <faure () kde ! org>
Date:       2010-09-14 17:30:58
Message-ID: 201009141930.59160.faure () kde ! org
[Download RAW message or body]

On Tuesday 14 September 2010, Albert Astals Cid wrote:
> A Dilluns, 13 de setembre de 2010, Albert Astals Cid va escriure:
> > A Dilluns, 13 de setembre de 2010, David Faure va escriure:
> > > On Monday 13 September 2010, Albert Astals Cid wrote:
> > > > klocale over a fake component being created for
> > > > some reason before the klocale with the correct component
> > > 
> > > I am very curious about the "for some reason" :-)
> > > 
> > > What's calling KGlobal::locale() before a main component is set?
> > 
> > In case of kpat is an invalid i18n call before the KApplication is
> > created, in other cases it might be the same. Of course those cases
> > should be detected and fixed but the punishment you get for the error is
> > too big if you ask me.
> 
> Wondering if it would sensible to put a big fat warning in that code to
> tell people they should have a look at their code and find out why a call
> to KGlobal::locale() is being done a main component is set.
> 
> What do you think?

I agree.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
[prev in list] [next in list] [prev in thread] [next in thread]