[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Cache returned KIconLoader pixmaps in 4.5.2
From:       Torgny Nyblom <kde () nyblom ! org>
Date:       2010-09-14 4:46:44
Message-ID: 20100914064644.60696b7c () explosive ! nyblom ! org
[Download RAW message or body]

On Mon, 13 Sep 2010 20:37:11 +0200
Ingo Klöcker <kloecker@kde.org> wrote:

[...]
> Maybe not, but something like
>   QString("%1_%2_%3").arg(name).arg(size).arg(overlays.join("_"))
> is completely braindead because it's horribly slow.
> 
> What about
>   return ( group == KIconLoader::User ? QLatin1Literal("$kicou_") :
> QLatin1Literal("$kico_") ) % name
>          % QLatin1Char('_')
>          % QString::number(size)
>          % QLatin1Char('_')
>          % overlays.join("_")
>          % ( group >= 0 ? mpEffect.fingerprint(group, state) :
> QString("noeffect") ); ?

Better.

/Regards
Torgny

[prev in list] [next in list] [prev in thread] [next in thread]