[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Implementing shift delete in dolphin, some help would be nice.
From: Mark <markg85 () gmail ! com>
Date: 2010-09-13 22:14:33
Message-ID: AANLkTik3DpgmUgoHLxjJBDHUwqjXNsPPCB+p-D_T=0pt () mail ! gmail ! com
[Download RAW message or body]
On Mon, Sep 13, 2010 at 11:13 PM, Lubos Lunak <l.lunak@suse.cz> wrote:
> On Monday 13 of September 2010, Mark wrote:
> > On Mon, Sep 13, 2010 at 10:00 PM, Mark <markg85@gmail.com> wrote:
> > > --- src/dolphincontextmenu.cpp (revision 1174907)
> > > +++ src/dolphincontextmenu.cpp (working copy)
> > > @@ -69,6 +69,9 @@
> > > const DolphinView* view =
> > > m_mainWindow->activeViewContainer()->view(); m_selectedUrls =
> > > view->selectedUrls();
> > > m_selectedItems = view->selectedItems();
> > > + m_keyInfo = new KModifierKeyInfo();
>
> And who deletes it?
>
Not in the above patch, but the destructor now does that:
DolphinContextMenu::~DolphinContextMenu()
>
> > Interesting, just found out that just having an instance
> > of KModifierKeyInfo (in the earlier diff: "m_keyInfo = new
> > KModifierKeyInfo();") blocks the GUI when shift is pressed and the right
> > mouse button.
>
>
> http://techbase.kde.org/Development/Tutorials/Debugging/How_to_create_useful_crash_reports#Retrieving_a_backtrace_with_GDB
> and see for yourself where it blocks.
>
Yea, i've got that suggestion on irc as well, but that's not really possible
to do with gdb (or i don't know how).
The dolphin interface blocks and the mouse gets extremely slow when i select
an item, press shift (hold it) and press right mouse botton, but as soon as
i lose focus of dolphin (which happens when i try to go to another app) it's
like the shift key is released (even while i'm still holding it) and dolphin
continues normally. This however makes it close to impossible to press CTRL
+ C in gdb to get the trace.
If you have any ideas, please do suggest them!
>
> --
> Lubos Lunak
> openSUSE Boosters team, KDE developer
> l.lunak@suse.cz , l.lunak@kde.org
>
[Attachment #3 (text/html)]
<div class="gmail_quote">On Mon, Sep 13, 2010 at 11:13 PM, Lubos Lunak <span \
dir="ltr"><<a href="mailto:l.lunak@suse.cz">l.lunak@suse.cz</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;">
<div class="im">On Monday 13 of September 2010, Mark wrote:<br>
> On Mon, Sep 13, 2010 at 10:00 PM, Mark <<a \
href="mailto:markg85@gmail.com">markg85@gmail.com</a>> wrote:<br> </div><div \
class="im">> > --- src/dolphincontextmenu.cpp (revision 1174907)<br> > > \
+++ src/dolphincontextmenu.cpp (working copy)<br> > > @@ -69,6 +69,9 @@<br>
> > const DolphinView* view =<br>
> > m_mainWindow->activeViewContainer()->view(); m_selectedUrls =<br>
> > view->selectedUrls();<br>
> > m_selectedItems = view->selectedItems();<br>
> > + m_keyInfo = new KModifierKeyInfo();<br>
<br>
</div> And who deletes it?<br></blockquote><div>Not in the above patch, but the \
destructor now does that: </div><meta name="qrichtext" content="1"><style \
type="text/css"> p, li { white-space: pre-wrap; }
</style>
DolphinContextMenu::~DolphinContextMenu()<font class="Apple-style-span" \
size="3"><span class="Apple-style-span" style="-webkit-border-horizontal-spacing: \
2px; -webkit-border-vertical-spacing: 2px;"><br></span></font><div>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;"> <div class="im"><br>
> Interesting, just found out that just having an instance<br>
> of KModifierKeyInfo (in the earlier diff: "m_keyInfo = new<br>
> KModifierKeyInfo();") blocks the GUI when shift is pressed and the \
right<br> > mouse button.<br>
<br>
</div><a href="http://techbase.kde.org/Development/Tutorials/Debugging/How_to_create_useful_crash_reports#Retrieving_a_backtrace_with_GDB" \
target="_blank">http://techbase.kde.org/Development/Tutorials/Debugging/How_to_create_useful_crash_reports#Retrieving_a_backtrace_with_GDB</a><br>
and see for yourself where it blocks.<br></blockquote><div>Yea, i've got that \
suggestion on irc as well, but that's not really possible to do with gdb (or i \
don't know how).</div><div>The dolphin interface blocks and the mouse gets \
extremely slow when i select an item, press shift (hold it) and press right mouse \
botton, but as soon as i lose focus of dolphin (which happens when i try to go to \
another app) it's like the shift key is released (even while i'm still \
holding it) and dolphin continues normally. This however makes it close to impossible \
to press CTRL + C in gdb to get the trace.</div>
<div><br></div><div>If you have any ideas, please do suggest them!</div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;"> <font color="#888888"><br>
--<br>
Lubos Lunak<br>
openSUSE Boosters team, KDE developer<br>
<a href="mailto:l.lunak@suse.cz">l.lunak@suse.cz</a> , <a \
href="mailto:l.lunak@kde.org">l.lunak@kde.org</a><br> </font></blockquote></div><br>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic