[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Allow formatting times without the hours-part,
From: "Tom Albers" <toma () kde ! org>
Date: 2010-08-26 18:58:50
Message-ID: 20100826185850.11212.71567 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5132/#review7235
-----------------------------------------------------------
Seems to work fine. I've adapted Spokify and tested the patch. It seems to =
work. A leading 0 for time < 10 minutes, can be discussed to let it all ali=
gn, but i dont think it is needed, as minutes could be more than 99 as well=
, which would break the layout again. I do not feel qualified to sign off o=
n a kdelibs patch though...
What remains is to thanks you for the quick patch!
- Tom
On 2010-08-24 11:12:20, Michael Leupold wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5132/
> -----------------------------------------------------------
> =
> (Updated 2010-08-24 11:12:20)
> =
> =
> Review request for kdelibs and Tom Albers.
> =
> =
> Summary
> -------
> =
> Add a new TimeFoldHours flag to the KLocale::TimeFormatOptions which allo=
ws the readLocaleTime/formatLocaleTime to remove the hours part of the time=
and add the hours*60 to the minutes part. This is useful when reading/form=
ating the duration of a song, eg. 70:00 instead of 01:10:00. Folding hours =
is only supported for durations.
> =
> @toma: CCed you as you requested this feature. Feel free to review if you=
feel like it though :-)
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdelibs/kdecore/localization/klocale.h 1167163 =
> /trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp 1167163 =
> /trunk/KDE/kdelibs/kdecore/tests/klocaletimeformattest.cpp 1167163 =
> =
> Diff: http://reviewboard.kde.org/r/5132/diff
> =
> =
> Testing
> -------
> =
> Added new testcases checking the new functionality to unit-tests. It migh=
t need 2 more testcases which I'll look into adding soon.
> =
> =
> Thanks,
> =
> Michael
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5132/">http://reviewboard.kde.org/r/5132/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems to work fine. \
I've adapted Spokify and tested the patch. It seems to work. A leading 0 for time \
< 10 minutes, can be discussed to let it all align, but i dont think it is needed, \
as minutes could be more than 99 as well, which would break the layout again. I do \
not feel qualified to sign off on a kdelibs patch though...
What remains is to thanks you for the quick patch!</pre>
<br />
<p>- Tom</p>
<br />
<p>On August 24th, 2010, 11:12 a.m., Michael Leupold wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Tom Albers.</div>
<div>By Michael Leupold.</div>
<p style="color: grey;"><i>Updated 2010-08-24 11:12:20</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add a new TimeFoldHours flag to the KLocale::TimeFormatOptions which \
allows the readLocaleTime/formatLocaleTime to remove the hours part of the time and \
add the hours*60 to the minutes part. This is useful when reading/formating the \
duration of a song, eg. 70:00 instead of 01:10:00. Folding hours is only supported \
for durations.
@toma: CCed you as you requested this feature. Feel free to review if you feel like \
it though :-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added new testcases checking the new functionality to unit-tests. It \
might need 2 more testcases which I'll look into adding soon.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdecore/localization/klocale.h <span style="color: \
grey">(1167163)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp <span style="color: \
grey">(1167163)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/tests/klocaletimeformattest.cpp <span style="color: \
grey">(1167163)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5132/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic