[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Use Qt cout and cerr
From: "Jaime Torres" <jtamate () gmail ! com>
Date: 2010-08-26 17:52:43
Message-ID: 20100826175243.6258.8895 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5158/
-----------------------------------------------------------
(Updated 2010-08-26 17:52:42.690593)
Review request for kdelibs.
Changes
-------
I used the anonymous namespace. But remember that kconfig_compiler.cpp gene=
rates an executable, it is not a shared library.
There are more global variables, but they will be classified (introduced in=
a class) in a later patch.
Also removed (and checked) the qPrintable macro.
Summary
-------
Use Qt cout and cerr. Qt already has in cout the methods for a lot of Qt da=
ta types.
Diffs (updated)
-----
/trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp 1168408 =
Diff: http://reviewboard.kde.org/r/5158/diff
Testing
-------
Works in linux and cygwin.
Thanks,
Jaime
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5158/">http://reviewboard.kde.org/r/5158/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres.</div>
<p style="color: grey;"><i>Updated 2010-08-26 17:52:42.690593</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I used the anonymous namespace. But remember that kconfig_compiler.cpp \
generates an executable, it is not a shared library. There are more global variables, \
but they will be classified (introduced in a class) in a later patch. Also removed \
(and checked) the qPrintable macro.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use Qt cout and cerr. Qt already has in cout the methods for a lot of Qt \
data types.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works in linux and cygwin.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp <span \
style="color: grey">(1168408)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5158/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic