[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: delete some unneded if(not null)
From: "Jaime Torres" <jtamate () gmail ! com>
Date: 2010-08-25 9:21:53
Message-ID: 20100825092153.7753.96467 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5021/
-----------------------------------------------------------
(Updated 2010-08-25 09:21:53.196527)
Review request for kdelibs.
Changes
-------
Added one more case. Removed the unwanted spaces.
Summary
-------
delete handles null pointers fine in c++
Diffs (updated)
-----
/trunk/KDE/kdelibs/dnssd/mdnsd-responder.cpp 1167520 =
/trunk/KDE/kdelibs/kate/syntax/katesyntaxdocument.cpp 1167520 =
/trunk/KDE/kdelibs/kde3support/kdeui/k3dockwidget_private.cpp 1167520 =
/trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp 1167520 =
/trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.cpp 1167520 =
/trunk/KDE/kdelibs/kdecore/localization/guess_ja_p.h 1167520 =
/trunk/KDE/kdelibs/kdecore/localization/probers/nsUniversalDetector.cpp 1=
167520 =
/trunk/KDE/kdelibs/kdeui/kernel/kapplication.cpp 1167520 =
/trunk/KDE/kdelibs/kdeui/tests/ktabwidgettest.cpp 1167520 =
/trunk/KDE/kdelibs/kdeui/widgets/kled.cpp 1167520 =
/trunk/KDE/kdelibs/kio/kssl/ksslpkcs12.cpp 1167520 =
/trunk/KDE/kdelibs/kio/kssl/ksslpkcs7.cpp 1167520 =
/trunk/KDE/kdelibs/kio/misc/ksendbugmail/smtp.cpp 1167520 =
/trunk/KDE/kdelibs/kioslave/http/http.cpp 1167520 =
/trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1167520 =
/trunk/KDE/kdelibs/plasma/containment.cpp 1167520 =
/trunk/KDE/kdelibs/plasma/packagestructure.cpp 1167520 =
/trunk/KDE/kdelibs/plasma/service.cpp 1167520 =
Diff: http://reviewboard.kde.org/r/5021/diff
Testing
-------
working with it.
Thanks,
Jaime
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5021/">http://reviewboard.kde.org/r/5021/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres.</div>
<p style="color: grey;"><i>Updated 2010-08-25 09:21:53.196527</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added one more case. Removed the unwanted spaces.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">delete handles null pointers fine in c++</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">working with it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/dnssd/mdnsd-responder.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kate/syntax/katesyntaxdocument.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kde3support/kdeui/k3dockwidget_private.cpp <span \
style="color: grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/localization/guess_ja_p.h <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/localization/probers/nsUniversalDetector.cpp <span \
style="color: grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/kernel/kapplication.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/tests/ktabwidgettest.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kled.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kio/kssl/ksslpkcs12.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kio/kssl/ksslpkcs7.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kio/misc/ksendbugmail/smtp.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/kioslave/http/http.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/plasma/abstractrunner.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/plasma/containment.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/plasma/packagestructure.cpp <span style="color: \
grey">(1167520)</span></li>
<li>/trunk/KDE/kdelibs/plasma/service.cpp <span style="color: \
grey">(1167520)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5021/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic