[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Move Konqueror throbber from menubar to the
From: "David Faure" <faure () kde ! org>
Date: 2010-08-23 5:45:11
Message-ID: 20100823054511.10554.17201 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4743/#review7160
-----------------------------------------------------------
Ship it!
Adam Treat (who moved the throbber to the menubar) said OK.
>From my own point of view, I'm happy to get rid of the icon size hacks in t=
he current code, they never really worked. Please commit.
- David
On 2010-08-18 11:12:25, Aur=C3=A9lien G=C3=A2teau wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4743/
> -----------------------------------------------------------
> =
> (Updated 2010-08-18 11:12:25)
> =
> =
> Review request for kdelibs and David Faure.
> =
> =
> Summary
> -------
> =
> Konqueror shows its throbber in the right corner of its menubar. This is =
a problem for the "application menu" project I am working on (see http://wi=
ki.ubuntu.com/DesktopExperienceTeam/ApplicationMenu ): custom widgets can't=
go through DBus.
> =
> Attached patch moves it to the toolbar. If there is interest, I could imp=
rove on it so that it does not display a button frame when the mouse is mov=
ed over it, since clicking it does not trigger any action (this was already=
the case when it was in the menubar).
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdebase/apps/konqueror/src/konqanimatedlogo.cpp 1147944 =
> trunk/KDE/kdebase/apps/konqueror/src/konqanimatedlogo_p.h 1147944 =
> trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1147944 =
> trunk/KDE/kdebase/apps/konqueror/src/konqueror.rc 1147944 =
> =
> Diff: http://reviewboard.kde.org/r/4743/diff
> =
> =
> Testing
> -------
> =
> - Tested in still and loading mode.
> - Verified the throbber resizes itself when the toolbar icon size is chan=
ged.
> =
> =
> Thanks,
> =
> Aur=C3=A9lien
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4743/">http://reviewboard.kde.org/r/4743/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adam Treat (who moved \
the throbber to the menubar) said OK.
> From my own point of view, I'm happy to get rid of the icon size hacks in the \
> current code, they never really worked. Please commit.</pre>
<br />
<p>- David</p>
<br />
<p>On August 18th, 2010, 11:12 a.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated 2010-08-18 11:12:25</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Konqueror shows its throbber in the right corner of its menubar. This is \
a problem for the "application menu" project I am working on (see \
http://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationMenu ): custom widgets \
can't go through DBus.
Attached patch moves it to the toolbar. If there is interest, I could improve on it \
so that it does not display a button frame when the mouse is moved over it, since \
clicking it does not trigger any action (this was already the case when it was in the \
menubar).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Tested in still and loading mode.
- Verified the throbber resizes itself when the toolbar icon size is changed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/apps/konqueror/src/konqanimatedlogo.cpp <span style="color: \
grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/apps/konqueror/src/konqanimatedlogo_p.h <span style="color: \
grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp <span style="color: \
grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/apps/konqueror/src/konqueror.rc <span style="color: \
grey">(1147944)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4743/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic