'Re: Review Request: Using KWallet to store Cookies'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Using KWallet to store Cookies
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2010-08-18 9:02:51
Message-ID: 20100818090251.25542.77827 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4927/#review7077
-----------------------------------------------------------


In addition to my review below, I have one question for you... Is it really necessary \
to have the "StoreWhenWalletNotAvaliable" option ?


/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp
<http://reviewboard.kde.org/r/4927/#comment7176>

    For performance reasons, it is always a good idea to keep the call to \
"blah.constEnd()" outside of the loop statement.  Perhaps even a Q_FOREACH would have \
sufficed here ?



/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp
<http://reviewboard.kde.org/r/4927/#comment7175>

    Why not "const QString& name" ?



/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.h
<http://reviewboard.kde.org/r/4927/#comment7177>

    Why not const "const QString& domain = QString()" here ?



/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp
<http://reviewboard.kde.org/r/4927/#comment7187>

    I have an issue with how mCookiesLoadedFromWallet is being used here. Though I \
understand why you are doing what you are doing, the flag looses its meaning \
nonetheless. Why not simply use a single OR 'ed if statement instead ?  
    if (!mUseWalletForCookies || mCookiesLoadedFromWallet || mTryingToObtainWallet || \
mTriedToObtainWallet)  return;
    
    That way it is straight forward to whomever has to deal with it in the future \
what is being done here...



/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp
<http://reviewboard.kde.org/r/4927/#comment7188>

    Same here... Why would failing to open the wallet result in the \
mCookieLoadedFromWallet flag being set to true ? At least some comment would be \
necessary. Better yet, if the logic above is followed, this won't be necessary, no ?



/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp
<http://reviewboard.kde.org/r/4927/#comment7189>

    The If here will also be unnecessary, if the logic change in \
"loadCookiesFromWallet" is applied...



/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp
<http://reviewboard.kde.org/r/4927/#comment7180>

    This entire if statement block belongs under the previous if statement block. \
There is no reason to repeat the same check again!


- Dawit


On 2010-08-07 18:41:38, José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4927/
> -----------------------------------------------------------
> 
> (Updated 2010-08-07 18:41:38)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Currently cookies are stored in a plain text file. This patch allows KCookieJar to \
> store the cookies securely using KWallet. 
> The main problem I had writing this patch was that when a web page is requested, \
> KIO ask for the cookies to kded using dbus. In the first implementations that I \
> wrote, if the user took too long to open the wallet, KIO received a dbus timeout. 
> To prevent this, if it takes more than 10 seconds to open the wallet, the web page \
> will be requested without sending the cookies (or sending the available cookies if \
> there's still the plain text cookie file). If the wallet is opened after that, the \
> cookies stored in the wallet will be available since then. 
> Because of this, the feature is disabled by default.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespolicies.cpp 1159393 
> /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespoliciesdlg.ui 1159393 
> /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.h 1159393 
> /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp 1159393 
> /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.h 1159393 
> /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp 1159393 
> 
> Diff: http://reviewboard.kde.org/r/4927/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4927/">http://reviewboard.kde.org/r/4927/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In addition to my review \
below, I have one question for you... Is it really necessary to have the \
&quot;StoreWhenWalletNotAvaliable&quot; option ?</pre>  <br />





<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4927/diff/1/?file=33099#file33099line1508" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool KCookieJar::loadCookies(KWallet::Wallet *wallet)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1508</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">for</span> <span class="p">(</span> <span class="n">QStringList</span><span \
class="o">::</span><span class="n">const_iterator</span> <span class="n">it</span> \
<span class="o">=</span> <span class="n">domainList</span><span \
class="p">.</span><span class="n">constBegin</span><span class="p">();</span> <span \
class="n">it</span> <span class="o">!=</span> <span class="n">domainList</span><span \
class="p">.</span><span class="n">constEnd</span><span class="p">();</span> <span \
class="n">it</span><span class="o">++</span> <span class="p">)</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For \
performance reasons, it is always a good idea to keep the call to \
&quot;blah.constEnd()&quot; outside of the loop statement.  Perhaps even a Q_FOREACH \
would have sufficed here ?</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4927/diff/1/?file=33099#file33099line1516" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool KCookieJar::loadCookies(KWallet::Wallet *wallet)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1516</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">Q_FOREACH</span><span class="p">(</span><span class="n">QString</span> \
<span class="n">name</span><span class="p">,</span> <span \
class="n">cookieNames</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why not \
&quot;const QString&amp; name&quot; ?</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4927/diff/1/?file=33100#file33100line106" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">106</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">  <span \
class="kt">void</span> <span class="n">loadCookiesFromWallet</span><span \
class="p">(</span><span class="n">QString</span> <span class="n">domain</span> <span \
class="o">=</span> <span class="s">&quot;&quot;</span><span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why not \
const &quot;const QString&amp; domain = QString()&quot; here ?</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4927/diff/1/?file=33101#file33101line132" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KCookieServer::KCookieServer(QObject* parent, const \
QList&lt;QVariant&gt;&amp;)</pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">96</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span \
class="k">if</span> <span class="p">(</span><span class="n">mCookieJar</span><span \
class="o">-&gt;</span><span class="n">saveCookies</span><span class="p">(</span> \
<span class="n">filename</span><span class="p">))</span></pre></td>  <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">132</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">mCookiesLoadedFromWallet</span> <span class="o">=</span> <span \
class="kc">true</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have an \
issue with how mCookiesLoadedFromWallet is being used here. Though I understand why \
you are doing what you are doing, the flag looses its meaning nonetheless. Why not \
simply use a single OR &#39;ed if statement instead ?

if (!mUseWalletForCookies || mCookiesLoadedFromWallet || mTryingToObtainWallet || \
mTriedToObtainWallet)  return;

That way it is straight forward to whomever has to deal with it in the future what is \
being done here...</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4927/diff/1/?file=33101#file33101line174" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KCookieServer::KCookieServer(QObject* parent, const \
QList&lt;QVariant&gt;&amp;)</pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">103</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span \
class="n">mCookieJar</span><span class="o">-&gt;</span><span \
class="n">loadCookies</span><span class="p">(</span> <span \
class="n">filename</span><span class="p">);</span></pre></td>  <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">174</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">mCookiesLoadedFromWallet</span> <span class="o">=</span> <span \
class="kc">true</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same \
here... Why would failing to open the wallet result in the mCookieLoadedFromWallet \
flag being set to true ? At least some comment would be necessary. Better yet, if the \
logic above is followed, this won&#39;t be necessary, no ?</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4927/diff/1/?file=33101#file33101line353" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KCookieServer::checkCookies( KHttpCookieList *cookieList)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">348</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">mCookiesLoadedFromWallet</span> <span class="o">&amp;&amp;</span> <span \
class="o">!</span><span class="n">mTriedToObtainWallet</span><span class="p">)</span> \
<span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The If here \
will also be unnecessary, if the logic change in &quot;loadCookiesFromWallet&quot; is \
applied...</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4927/diff/1/?file=33101#file33101line358" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KCookieServer::checkCookies( KHttpCookieList *cookieList)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">353</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span> <span class="p">(</span><span \
class="n">mUseWalletForCookies</span> <span class="o">&amp;&amp;</span> <span \
class="n">mCookiesLoadedFromWallet</span><span class="p">)</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This entire \
if statement block belongs under the previous if statement block. There is no reason \
to repeat the same check again!</pre> </div>
<br />



<p>- Dawit</p>


<br />
<p>On August 7th, 2010, 6:41 p.m., José Millán Soto wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By José Millán Soto.</div>


<p style="color: grey;"><i>Updated 2010-08-07 18:41:38</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently cookies are stored in a plain text file. This patch allows \
KCookieJar to store the cookies securely using KWallet.

The main problem I had writing this patch was that when a web page is requested, KIO \
ask for the cookies to kded using dbus. In the first implementations that I wrote, if \
the user took too long to open the wallet, KIO received a dbus timeout.

To prevent this, if it takes more than 10 seconds to open the wallet, the web page \
will be requested without sending the cookies (or sending the available cookies if \
there&#39;s still the plain text cookie file). If the wallet is opened after that, \
the cookies stored in the wallet will be available since then.

Because of this, the feature is disabled by default.</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespolicies.cpp <span \
style="color: grey">(1159393)</span></li>

 <li>/trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespoliciesdlg.ui <span \
style="color: grey">(1159393)</span></li>

 <li>/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.h <span style="color: \
grey">(1159393)</span></li>

 <li>/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp <span style="color: \
grey">(1159393)</span></li>

 <li>/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.h <span style="color: \
grey">(1159393)</span></li>

 <li>/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp <span \
style="color: grey">(1159393)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4927/diff/" style="margin-left: 3em;">View \
Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic