'Re: Review Request: Make DBusMenuQt optional'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Make DBusMenuQt optional
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2010-08-04 16:08:32
Message-ID: 20100804160832.31083.96071 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4898/#review6793
-----------------------------------------------------------


The change looks OK, but I am wondering why you do not want to link with DB=
usMenuQt. Having (very) different code paths is potentially a source of tro=
uble for maintenance.

- Aur=C3=A9lien


On 2010-08-04 09:37:48, Marc Mutz wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4898/
> -----------------------------------------------------------
> =

> (Updated 2010-08-04 09:37:48)
> =

> =

> Review request for kdelibs.
> =

> =

> Summary
> -------
> =

> Make DBusMenuQt optional.
> =

> =

> Diffs
> -----
> =

>   /branches/KDE/4.5/kdelibs/CMakeLists.txt 1159039 =

>   /branches/KDE/4.5/kdelibs/ConfigureChecks.cmake 1159039 =

>   /branches/KDE/4.5/kdelibs/config.h.cmake 1159039 =

>   /branches/KDE/4.5/kdelibs/kdeui/CMakeLists.txt 1159039 =

>   /branches/KDE/4.5/kdelibs/kdeui/notifications/kstatusnotifieritem.cpp 1=
159039 =

> =

> Diff: http://reviewboard.kde.org/r/4898/diff
> =

> =

> Testing
> -------
> =

> Compiles w/o DBusMenuQt present.
> =

> =

> Thanks,
> =

> Marc
> =

>


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4898/">http://reviewboard.kde.org/r/4898/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The change looks OK, but \
I am wondering why you do not want to link with DBusMenuQt. Having (very) different \
code paths is potentially a source of trouble for maintenance.</pre>  <br />







<p>- Aurélien</p>


<br />
<p>On August 4th, 2010, 9:37 a.m., Marc Mutz wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Marc Mutz.</div>


<p style="color: grey;"><i>Updated 2010-08-04 09:37:48</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make DBusMenuQt optional.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles w/o DBusMenuQt present.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/KDE/4.5/kdelibs/CMakeLists.txt <span style="color: \
grey">(1159039)</span></li>

 <li>/branches/KDE/4.5/kdelibs/ConfigureChecks.cmake <span style="color: \
grey">(1159039)</span></li>

 <li>/branches/KDE/4.5/kdelibs/config.h.cmake <span style="color: \
grey">(1159039)</span></li>

 <li>/branches/KDE/4.5/kdelibs/kdeui/CMakeLists.txt <span style="color: \
grey">(1159039)</span></li>

 <li>/branches/KDE/4.5/kdelibs/kdeui/notifications/kstatusnotifieritem.cpp <span \
style="color: grey">(1159039)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4898/diff/" style="margin-left: 3em;">View \
Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic