--===============2851232077768877668== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4901/ ----------------------------------------------------------- Review request for kdelibs. Summary ------- Recently, the handling of spell checking for upper-case words was fixed in = Sonnet::Filter. While this might now work correctly with KTextEdit widgets = through Sonnet::Highlighter, although potentially configured differently up= per-case words might still be spell checked with Sonnet::BackgroundChecker.= This is due to the fact that Sonnet::BackgroundChecker does not possess a = way to load or reload specific spell checking configurations. This patch fixes the problem by adding a 'restore' method to Sonnet::Backgr= oundChecker, which allows it to read a spell checking configuration and the= n to pass it on to the filter object that is used internally. The implement= ation is similar to what is done inside Sonnet::Highlighter. This patch should also be back-ported to 4.5 eventually. Diffs ----- trunk/KDE/kdelibs/kdecore/sonnet/backgroundchecker.h 1159072 = trunk/KDE/kdelibs/kdecore/sonnet/backgroundchecker.cpp 1159072 = Diff: http://reviewboard.kde.org/r/4901/diff Testing ------- Thanks, Michel --===============2851232077768877668== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4901/

Review request for kdelibs.
By Michel Ludwig.

Descripti= on

Recently, the handling of spell checking for upper-case word=
s was fixed in Sonnet::Filter. While this might now work correctly with KTe=
xtEdit widgets through Sonnet::Highlighter, although potentially configured=
 differently upper-case words might still be spell checked with Sonnet::Bac=
kgroundChecker. This is due to the fact that Sonnet::BackgroundChecker does=
 not possess a way to load or reload specific spell checking configurations.

This patch fixes the problem by adding a 'restore' method to Sonnet=
::BackgroundChecker, which allows it to read a spell checking configuration=
 and then to pass it on to the filter object that is used internally. The i=
mplementation is similar to what is done inside Sonnet::Highlighter.

This patch should also be back-ported to 4.5 eventually.

Diffs=

  • trunk/KDE/kdelibs/kdecore/sonnet/backgroundchecker.h (1159072)
  • trunk/KDE/kdelibs/kdecore/sonnet/backgroundchecker.cpp (1159072)

View Diff

--===============2851232077768877668==--