[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    NetAccess::statInternal and showing job progress
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2010-07-16 18:42:48
Message-ID: 201007161142.53069.aseigo () kde ! org
[Download RAW message or body]


hi ...

NetAccess::statInternal is a private method and is used by calls to the 
NetAccess methods for stat and exists. if the url is remote, it shows job 
progress. this means that for every file that is stat'd or checked for 
existene over the network (e.g. fish), we get a job notification.

this results in apps like ksnapshot, when used to save to a remote location, 
throwing up job notifications on start up.

it also means causing a lot of traffic in the job UI server infrastructure 
just to show what is, imho, fairly uninteresting information to the user.

i have a simple patch here which changes this:

Index: ../kio/kio/netaccess.cpp
===================================================================
--- ../kio/kio/netaccess.cpp    (revision 1130620)
+++ ../kio/kio/netaccess.cpp    (working copy)
@@ -345,7 +345,7 @@
                               QWidget* window )
 {
   d->bJobOK = true; // success unless further error occurs
-  KIO::JobFlags flags = url.isLocalFile() ? KIO::HideProgressInfo : 
KIO::DefaultFlags;
+  KIO::JobFlags flags = KIO::HideProgressInfo;
   KIO::StatJob * job = KIO::stat( url, flags );
   job->ui()->setWindow (window);
   job->setDetails( details );


is there any pressing reason to show the progress info for stat/exist checks 
on remote files? i'd like to commit this and backport if there is consensus.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]