[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: KIO : Remote preview
From: "Peter Penz" <peter.penz () gmx ! at>
Date: 2010-07-14 21:06:15
Message-ID: 20100714210615.13910.98262 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4627/#review6566
-----------------------------------------------------------
Ship it!
Thanks for the patch, looks fine! Yes, the maximum size for remote files should never get ignored and \
this must be fixed. I've added a small suggestion below for the code, but it's just a suggestion. Please \
commit to trunk and the 4.5 branch :-) (or let me know if I should commit the patch for you)
/trunk/KDE/kdelibs/kio/kio/previewjob.cpp
<http://reviewboard.kde.org/r/4627/#comment6324>
Only a minor suggestion: I think the code might get slightly more readable when storing the \
entry.numberValue() first. Also I'd suggest to always initialize scalar types (even we know in this case, \
that it is initialized after the if for sure).
bool skipCurrentItem = false;
const KIO::filesize_t size = (KIO::filesize_t)entry.numberValue( KIO::UDSEntry::UDS_SIZE, 0 );
if (d->currentItem.item.url().isLocalFile())
{
skipCurrentItem = !d->ignoreMaximumSize && size > d->maximumLocalSize
&& !d->currentItem.plugin->property("IgnoreMaximumSize").toBool();
}
else
{
// If remote, ignore the "IgnoreMaximumSize" plugin property
skipCurrentItem = !d->ignoreMaximumSize && size > d->maximumRemoteSize;
}
- Peter
On 2010-07-14 14:30:11, Iamluc wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4627/
> -----------------------------------------------------------
>
> (Updated 2010-07-14 14:30:11)
>
>
> Review request for kdelibs and Peter Penz.
>
>
> Summary
> -------
>
> Hi,
>
> There is a size limit for remote previews in Dolphin. By default, the limit is set to 0, so there is no \
> preview for remote files. But a ThumbCreator plugin can ignore this limit by setting \
> "IgnoreMaximumSize=true" in the protocol .desktop file (like the ffmpegthumbnails creator).
> This patch forces to ignore this property when using a remote protocol.
>
> Luc.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1149793
>
> Diff: http://reviewboard.kde.org/r/4627/diff
>
>
> Testing
> -------
>
> Tested with SFTP and FTP kio slaves. Files are not downloaded anymore.
>
>
> Thanks,
>
> Iamluc
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4627/">http://reviewboard.kde.org/r/4627/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>Thanks for the patch, looks fine! Yes, the maximum size for remote files should never get ignored \
and this must be fixed. I've added a small suggestion below for the code, but it's just a \
suggestion. Please commit to trunk and the 4.5 branch :-) (or let me know if I should commit the patch \
for you)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a href="/r/4627/diff/1/?file=31188#file31188line353" style="color: black; \
font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/kio/kio/previewjob.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;">void PreviewJob::slotResult( KJob *job )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">353</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> <span class="k">const</span> \
<span class="n">KIO</span><span class="o">::</span><span class="n">filesize_t</span> <span \
class="n">maximumSize</span> <span class="o">=</span> <span class="n">d</span><span \
class="o">-></span><span class="n">currentItem</span><span class="p">.</span><span \
class="n">item</span><span class="p">.</span><span class="n">url</span><span class="p">().</span><span \
class="n">isLocalFile</span><span class="p">()</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">353</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> <span class="kt">bool</span> \
<span class="n">skipCurrentItem</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em">Only a minor suggestion: I think the code might get slightly more readable \
when storing the entry.numberValue() first. Also I'd suggest to always initialize scalar types (even \
we know in this case, that it is initialized after the if for sure).
bool skipCurrentItem = false;
const KIO::filesize_t size = (KIO::filesize_t)entry.numberValue( KIO::UDSEntry::UDS_SIZE, 0 );
if (d->currentItem.item.url().isLocalFile())
{
skipCurrentItem = !d->ignoreMaximumSize && size > d->maximumLocalSize
&& \
!d->currentItem.plugin->property("IgnoreMaximumSize").toBool(); }
else
{
// If remote, ignore the "IgnoreMaximumSize" plugin property
skipCurrentItem = !d->ignoreMaximumSize && size > d->maximumRemoteSize;
}</pre>
</div>
<br />
<p>- Peter</p>
<br />
<p>On July 14th, 2010, 2:30 p.m., Iamluc wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; \
background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs and Peter Penz.</div>
<div>By Iamluc.</div>
<p style="color: grey;"><i>Updated 2010-07-14 14:30:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Hi,
There is a size limit for remote previews in Dolphin. By default, the limit is set to 0, so there is no \
preview for remote files. But a ThumbCreator plugin can ignore this limit by setting \
"IgnoreMaximumSize=true" in the protocol .desktop file (like the ffmpegthumbnails creator).
This patch forces to ignore this property when using a remote protocol.
Luc.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Tested with SFTP and FTP kio slaves. Files are not downloaded \
anymore. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kio/kio/previewjob.cpp <span style="color: grey">(1149793)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4627/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic