'Re: Review Request: Adding "net usershare" suport for KSambaShare'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Adding "net usershare" suport for KSambaShare
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2010-07-13 15:55:33
Message-ID: 20100713155533.3265.98071 () localhost
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4320/#review6531
-----------------------------------------------------------


It would be simpler I think if KSambaShareInfo were value-based. It would make it \
easier to manipulate it without leaks. It inherits from QObject right now, which \
                prevents making it value-based. I suggest the following changes:
- In KSambaSharePrivate::shareChange(), instead of emitting a signal, modify the \
                relevant KSambaShareInfo instance directly
- Remove the slot
- Do not inherit from QObject
- Make KSambaShareInfo inherit from QSharedData

When this is done you can simplify KSambaShare::add() a bit by turning its signature \
into "void KSambaShare::add(const KSambaShareInfo& info)"

Other suggestions:
- Move KSambaSharePrivate::add() into KSambaShareInfo::save()


/trunk/KDE/kdelibs/kio/kio/ksambadata_p.h
<http://reviewboard.kde.org/r/4320/#comment6270>

    Would be nice to document the content of this "data" member



/trunk/KDE/kdelibs/kio/kio/ksambashare.h
<http://reviewboard.kde.org/r/4320/#comment6271>

    isShareNameAvailable() sounds more english



/trunk/KDE/kdelibs/kio/kio/ksambashare.h
<http://reviewboard.kde.org/r/4320/#comment6272>

    What is the reason for the change from private: to protected: here?



/trunk/KDE/kdelibs/kio/kio/ksambashare.h
<http://reviewboard.kde.org/r/4320/#comment6273>

    You can't add shareList here, it would break binary compatibility. You have to \
keep it in the KSambaSharePrivate object.



/trunk/KDE/kdelibs/kio/kio/ksambashare.cpp
<http://reviewboard.kde.org/r/4320/#comment6275>

    rawData should be "const QByteArray&" instead of "QByteArray&"



/trunk/KDE/kdelibs/kio/kio/ksambashare.cpp
<http://reviewboard.kde.org/r/4320/#comment6274>

    This method leaks KProcess objects. Have a look at my previous suggestions to fix \
that.



/trunk/KDE/kdelibs/kio/kio/ksambashare.cpp
<http://reviewboard.kde.org/r/4320/#comment6276>

    Are you sure this test works?
    
    You implemented operator==() for KSambaShareInfo, but since shareList is a list \
of pointers, I don't think QList::contains() is going to use \
KSambaShareInfo::operator==() but rather only compares the addresses of the objects.


- Aurélien


On 2010-07-11 00:59:35, Rodrigo Belem wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4320/
> -----------------------------------------------------------
> 
> (Updated 2010-07-11 00:59:35)
> 
> 
> Review request for kdelibs, Jonathan Thomas, Aurélien Gâteau, Jonathan Riddell, \
> and Adenilson Cavalcanti. 
> 
> Summary
> -------
> 
> KDE needs to support modern samba tools. With the "net usershare" command line tool \
> the users can manage their shares. The attached patch intends to add support for \
> this tool. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kio/CMakeLists.txt 1137974 
> /trunk/KDE/kdelibs/kio/kio/ksambadata_p.h PRE-CREATION 
> /trunk/KDE/kdelibs/kio/kio/ksambashare.h 1137974 
> /trunk/KDE/kdelibs/kio/kio/ksambashare.cpp 1137974 
> /trunk/KDE/kdelibs/kio/kio/ksambashare_p.h PRE-CREATION 
> /trunk/KDE/kdelibs/kio/kio/ksambashareinfo.h PRE-CREATION 
> /trunk/KDE/kdelibs/kio/kio/ksambashareinfo.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4320/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rodrigo
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4320/">http://reviewboard.kde.org/r/4320/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre>It would be simpler I think if KSambaShareInfo were value-based. It would make \
it easier to manipulate it without leaks. It inherits from QObject right now, which \
                prevents making it value-based. I suggest the following changes:
- In KSambaSharePrivate::shareChange(), instead of emitting a signal, modify the \
                relevant KSambaShareInfo instance directly
- Remove the slot
- Do not inherit from QObject
- Make KSambaShareInfo inherit from QSharedData

When this is done you can simplify KSambaShare::add() a bit by turning its signature \
into &quot;void KSambaShare::add(const KSambaShareInfo&amp; info)&quot;

Other suggestions:
- Move KSambaSharePrivate::add() into KSambaShareInfo::save()</pre>
 <br />





<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4320/diff/5/?file=30745#file30745line44" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/KDE/kdelibs/kio/kio/ksambadata_p.h</a>  \
<span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td>  <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;">private:</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">44</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">    \
<span class="n">QMap</span><span class="o">&lt;</span><span \
class="n">QString</span><span class="p">,</span> <span class="n">QMap</span><span \
class="o">&lt;</span><span class="n">QString</span><span class="p">,</span> <span \
class="n">QString</span><span class="o">&gt;</span> <span class="o">&gt;</span> <span \
class="n">data</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em">Would be nice to document the content of this \
&quot;data&quot; member</pre> </div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4320/diff/5/?file=30746#file30746line60" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/KDE/kdelibs/kio/kio/ksambashare.h</a>  \
<span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">58</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">    \
<span class="n">bool</span> <span class="n">shareNameAvailable</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span><span \
class="o">&amp;</span> <span class="n">name</span><span class="p">)</span> <span \
class="k">const</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em">isShareNameAvailable() sounds more english</pre>
</div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4320/diff/5/?file=30746#file30746line134" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/KDE/kdelibs/kio/kio/ksambashare.h</a>  \
<span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">74</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"><span class="nl">private:</span></pre></td>  <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">132</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: \
pre-wrap; word-wrap: break-word;"><span class="nl">protected:</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em">What is the reason for the change from private: to \
protected: here?</pre> </div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4320/diff/5/?file=30746#file30746line140" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/KDE/kdelibs/kio/kio/ksambashare.h</a>  \
<span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">138</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">    \
<span class="n">QList</span><span class="o">&lt;</span><span \
class="n">KSambaShareInfo</span> <span class="o">*&gt;</span> <span \
class="n">shareList</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em">You can&#39;t add shareList here, it would break binary \
compatibility. You have to keep it in the KSambaSharePrivate object.</pre> </div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4320/diff/5/?file=30747#file30747line101" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/KDE/kdelibs/kio/kio/ksambashare.cpp</a>  \
<span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">bool \
KSambaShare::KSambaSharePrivate::load()</pre></td>  <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;">bool KSambaDataPrivate::sync(QByteArray&amp; \
rawData)</pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">71</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"><span class="kt">bool</span> <span \
class="n">KSambaShare</span><span class="o">::</span><span \
class="n">KSambaSharePrivate</span><span class="o">::</span><span \
class="n">load</span><span class="p">()</span></pre></td>  <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">84</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"><span class="kt">bool</span> <span \
class="n">KSambaDataPrivate</span><span class="o">::</span><span \
class="n">sync</span><span class="p">(</span><span class="n">QByteArray</span><span \
class="o">&amp;</span> <span class="n">rawData</span><span \
class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em">rawData should be &quot;const QByteArray&amp;&quot; \
instead of &quot;QByteArray&amp;&quot;</pre> </div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4320/diff/5/?file=30747#file30747line196" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/KDE/kdelibs/kio/kio/ksambashare.cpp</a>  \
<span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td>  <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;">KProcess* KSambaSharePrivate::runProcess(const QString&amp; \
progName, const QStringList&amp; args,</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">165</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: \
break-word;"><span class="n">KProcess</span><span class="o">*</span> <span \
class="n">KSambaSharePrivate</span><span class="o">::</span><span \
class="n">runProcess</span><span class="p">(</span><span class="k">const</span> <span \
class="n">QString</span><span class="o">&amp;</span> <span \
class="n">progName</span><span class="p">,</span> <span class="k">const</span> <span \
class="n">QStringList</span><span class="o">&amp;</span> <span \
class="n">args</span><span class="p">,</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em">This method leaks KProcess objects. Have a look at my \
previous suggestions to fix that.</pre> </div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4320/diff/5/?file=30747#file30747line508" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/KDE/kdelibs/kio/kio/ksambashare.cpp</a>  \
<span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td>  <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;">void KSambaShare::fileChange(const QString&amp; \
path)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">458</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">    \
<span class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">shareList</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span class="n">tmp</span><span \
class="p">))</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em">Are you sure this test works?

You implemented operator==() for KSambaShareInfo, but since shareList is a list of \
pointers, I don&#39;t think QList::contains() is going to use \
KSambaShareInfo::operator==() but rather only compares the addresses of the \
objects.</pre> </div>
<br />



<p>- Aurélien</p>


<br />
<p>On July 11th, 2010, 12:59 a.m., Rodrigo Belem wrote:</p>




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs, Jonathan Thomas, Aurélien Gâteau, Jonathan \
Riddell, and Adenilson Cavalcanti.</div> <div>By Rodrigo Belem.</div>


<p style="color: grey;"><i>Updated 2010-07-11 00:59:35</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">KDE needs to support modern samba tools. With \
the &quot;net usershare&quot; command line tool the users can manage their shares. \
The attached patch intends to add support for this tool.</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdelibs/kio/CMakeLists.txt <span style="color: \
grey">(1137974)</span></li>

 <li>/trunk/KDE/kdelibs/kio/kio/ksambadata_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdelibs/kio/kio/ksambashare.h <span style="color: \
grey">(1137974)</span></li>

 <li>/trunk/KDE/kdelibs/kio/kio/ksambashare.cpp <span style="color: \
grey">(1137974)</span></li>

 <li>/trunk/KDE/kdelibs/kio/kio/ksambashare_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdelibs/kio/kio/ksambashareinfo.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdelibs/kio/kio/ksambashareinfo.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4320/diff/" style="margin-left: 3em;">View \
Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic