[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: KDiskFreeSpaceInfo: report correct free space on
From: "Sebastian Trueg" <trueg () kde ! org>
Date: 2010-07-13 8:11:38
Message-ID: 20100713081138.24165.58692 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4551/#review6522
-----------------------------------------------------------
Ship it!
Looks fine to me. I am no expert but from my Google "research" and test on =
Linux this seems like the correct approach.
- Sebastian
On 2010-07-08 18:44:00, Max Brazhnikov wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4551/
> -----------------------------------------------------------
> =
> (Updated 2010-07-08 18:44:00)
> =
> =
> Review request for kdelibs.
> =
> =
> Summary
> -------
> =
> bsize is eight times greater than frsize on FreeBSD with default ufs2 fil=
esystem, therefore KDiskFreeSpaceInfo reports incorrect free space.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdelibs/kio/kfile/kdiskfreespaceinfo.cpp 1147566 =
> =
> Diff: http://reviewboard.kde.org/r/4551/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Max
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4551/">http://reviewboard.kde.org/r/4551/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>Looks fine to me. I am no expert but from my Google "research" and \
test on Linux this seems like the correct approach.</pre> <br />
<p>- Sebastian</p>
<br />
<p>On July 8th, 2010, 6:44 p.m., Max Brazhnikov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Max Brazhnikov.</div>
<p style="color: grey;"><i>Updated 2010-07-08 18:44:00</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">bsize is eight times greater than frsize on \
FreeBSD with default ufs2 filesystem, therefore KDiskFreeSpaceInfo reports incorrect \
free space.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kio/kfile/kdiskfreespaceinfo.cpp <span style="color: \
grey">(1147566)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4551/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic