Ship it!
Sounds good to me, I am very much in favor of using the same code on all platforms ;)
- David
On May 10th, 2010, 6:38 p.m., Ilie Halip wrote:
|
Review request for kdelibs, George Kiagiadakis and Patrick Spendrin.
By Ilie Halip.
Updated 2010-05-10 18:38:48
Description
This patch fixes the problem reported here: https://bugs.kde.org/show_bug.cgi?id=207162
It was a problem that I think happened all over KDE on Windows, because the kio_file slave was reporting incorrect information (S_IFREG for non-existing files). I removed the createUDSEntryWin function, and moved FileProtocol::stat inside file.cpp, because both unix and win now have a common implementation.
|
Testing
listing files in directories
saving/loading files from ktuberling with/without extension
|
Diffs
- trunk/KDE/kdelibs/kioslave/file/file.cpp (1124299)
- trunk/KDE/kdelibs/kioslave/file/file_unix.cpp (1124299)
- trunk/KDE/kdelibs/kioslave/file/file_win.cpp (1124299)
View Diff
|