From kde-core-devel Tue Jul 13 07:59:28 2010 From: "David Faure" Date: Tue, 13 Jul 2010 07:59:28 +0000 To: kde-core-devel Subject: Re: Review Request: fixed file kioslave on windows (it was reporting Message-Id: <20100713075928.23897.70023 () localhost> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=127900802211102 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8477260666261558684==" --===============8477260666261558684== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3938/#review6521 ----------------------------------------------------------- Ship it! Sounds good to me, I am very much in favor of using the same code on all pl= atforms ;) - David On 2010-05-10 18:38:48, Ilie Halip wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3938/ > ----------------------------------------------------------- > = > (Updated 2010-05-10 18:38:48) > = > = > Review request for kdelibs, George Kiagiadakis and Patrick Spendrin. > = > = > Summary > ------- > = > This patch fixes the problem reported here: https://bugs.kde.org/show_bug= .cgi?id=3D207162 > = > It was a problem that I think happened all over KDE on Windows, because t= he kio_file slave was reporting incorrect information (S_IFREG for non-exis= ting files). I removed the createUDSEntryWin function, and moved FileProtoc= ol::stat inside file.cpp, because both unix and win now have a common imple= mentation. > = > = > This addresses bug 207162. > https://bugs.kde.org/show_bug.cgi?id=3D207162 > = > = > Diffs > ----- > = > trunk/KDE/kdelibs/kioslave/file/file.cpp 1124299 = > trunk/KDE/kdelibs/kioslave/file/file_unix.cpp 1124299 = > trunk/KDE/kdelibs/kioslave/file/file_win.cpp 1124299 = > = > Diff: http://reviewboard.kde.org/r/3938/diff > = > = > Testing > ------- > = > listing files in directories > saving/loading files from ktuberling with/without extension > = > = > Thanks, > = > Ilie > = > --===============8477260666261558684== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/3938/

Ship it!

Sounds good to me, I am very much in favor of using the same code on =
all platforms ;)

- David


On May 10th, 2010, 6:38 p.m., Ilie Halip wrote:

Review request for kdelibs, George Kiagiadakis and Patrick Spendrin.
By Ilie Halip.

Updated 2010-05-10 18:38:48

Descripti= on 

This patch fixes the problem repor=
ted here: https://bugs.kde.org/show_bug.cgi?id=3D207162

It was a problem that I think happened all over KDE on Windows, because the=
 kio_file slave was reporting incorrect information (S_IFREG for non-existi=
ng files). I removed the createUDSEntryWin function, and moved FileProtocol=
::stat inside file.cpp, because both unix and win now have a common impleme=
ntation.

Testing <= /h1> 
listing files in directories
saving/loading files from ktuberling with/without extension
Bugs: 207162

Diffs=

  • trunk/KDE/kdelibs/kioslave/file/file.cpp (= 1124299)
  • trunk/KDE/kdelibs/kioslave/file/file_unix.cpp (1124299)
  • trunk/KDE/kdelibs/kioslave/file/file_win.cpp (1124299)

View Diff
--===============8477260666261558684==--