[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Do not fallback to Hicolor when Oxygen provides a
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2010-06-20 9:18:38
Message-ID: 20100620091838.10208.55026 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4403/
-----------------------------------------------------------
Review request for kdelibs and Rafael Fern=C3=A1ndez L=C3=B3pez.
Summary
-------
When loading an icon for video-mp4, KIconLoader incorrectly returns "video.=
png" from Hicolor, instead of returning "video-x-generic.png" from Oxygen. =
Since Hicolor only has a 16x16 version, this results in blurry icons in Dol=
phin or Gwenview when icons are bigger than 16x16.
This is because the current code fallbacks to Hicolor before looking for a =
"-x-generic" version.
Diffs
-----
trunk/KDE/kdelibs/kdeui/icons/kiconloader.cpp 1140302 =
trunk/KDE/kdelibs/kdeui/tests/kiconloader_unittest.cpp 1140302 =
Diff: http://reviewboard.kde.org/r/4403/diff
Testing
-------
- Added a unit-test entry to check we get video-x-generic.
- Icons are no longer blurry after the patch.
Thanks,
Aur=C3=A9lien
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4403/">http://reviewboard.kde.org/r/4403/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Rafael Fernández López.</div>
<div>By Aurélien Gâteau.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">When loading an icon for video-mp4, \
KIconLoader incorrectly returns "video.png" from Hicolor, instead of \
returning "video-x-generic.png" from Oxygen. Since Hicolor only has a 16x16 \
version, this results in blurry icons in Dolphin or Gwenview when icons are bigger \
than 16x16.
This is because the current code fallbacks to Hicolor before looking for a \
"-x-generic" version.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">- Added a unit-test entry to check we get \
video-x-generic.
- Icons are no longer blurry after the patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kdeui/icons/kiconloader.cpp <span style="color: \
grey">(1140302)</span></li>
<li>trunk/KDE/kdelibs/kdeui/tests/kiconloader_unittest.cpp <span style="color: \
grey">(1140302)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4403/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic