[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: KTimeZoneWidget: Display country name instead of
From:       "John Layt" <johnlayt () googlemail ! com>
Date:       2010-06-08 11:36:16
Message-ID: 20100608113616.8769.60030 () localhost
[Download RAW message or body]



> On 2010-06-07 22:37:40, David Jarvie wrote:
> > There seems to be a problem in that time zones are not available when you run a \
> > KDE application under a different KDE version desktop. Under a trunk desktop the \
> > time zones are available; when I run a trunk app under KDE 4.3, the time zones \
> > are not available. This is probably a bug :(
> 
> Parker Coates wrote:
> Are you sure the trunk application is actually using the trunk kdelibs?
> 
> David Jarvie wrote:
> It would surely produce link errors and crash if it wasn't using trunk kdelibs.

Committed r1135929.  Should I backport to 4.4?

Yes, we don't quite cover all countries in l10n.  That should improve in 4.6 if we \
switch to using the isocodes project translations.

We could probably improve things further in 4.6 (sortable columns, do we really need \
the region name, etc), we can discuss at Akademy.

On my setup the trunk app is definitely using trunk kdelibs, it's using new kdelibs \
features I've added.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4247/#review6027
-----------------------------------------------------------


On 2010-06-06 22:20:31, John Layt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4247/
> -----------------------------------------------------------
> 
> (Updated 2010-06-06 22:20:31)
> 
> 
> Review request for kdelibs, David Jarvie and David Faure.
> 
> 
> Summary
> -------
> 
> The KTimeZoneWidget lists the city name and region name, but only the country code, \
> which is not good usability as users may not know their country code, cannot search \
> on their country name, and it is not always obvious what city is listed for their \
> timezone. 
> 
> This addresses bug 151636.
> https://bugs.kde.org/show_bug.cgi?id=151636
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kdeui/widgets/ktimezonewidget.cpp 1135123 
> 
> Diff: http://reviewboard.kde.org/r/4247/diff
> 
> 
> Testing
> -------
> 
> It compiles :-)  I tried testing but my 4.5 dev system won't load the zonetab.  Can \
> someone please check for me, or point me to how to get the zonetab to load? 
> 
> Thanks,
> 
> John
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]