[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: When a source file for kconf_update does not
From: "Kevin Krammer" <kevin.krammer () gmx ! at>
Date: 2010-06-07 11:38:56
Message-ID: 20100607113856.17613.88929 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4243/
-----------------------------------------------------------
(Updated 2010-06-07 11:38:56.566534)
Review request for kdelibs.
Changes
-------
Add unitttest
Summary
-------
Currently, when kconf_update is being run by kdeinit4 on a new user account, it \
creates all config files that it has updates for, regardless whether these files \
exist. Which mean .kde/share/config gets populated with a lot of files with only \
kconf_update's entry in them.
Unfortunately that means that programs checking for a specific file's existance, e.g. \
PIM apps which are checking whether to run a migrator tool, will be fooled into \
assuming that there are actually valid settings.
The patch uses the already set m_skipFile flag to decide when not to sync the KConfig \
object, thus not creating the file if it didn't exist before
Diffs (updated)
-----
/trunk/KDE/kdelibs/kconf_update/kconf_update.cpp 1135468
/trunk/KDE/kdelibs/kconf_update/tests/test_kconf_update.h 1135468
/trunk/KDE/kdelibs/kconf_update/tests/test_kconf_update.cpp 1135468
Diff: http://reviewboard.kde.org/r/4243/diff
Testing
-------
Thanks,
Kevin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic