[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: When a source file for kconf_update does not
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2010-06-07 9:41:06
Message-ID: 20100607094106.14758.75372 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4243/#review6006
-----------------------------------------------------------

Ship it!


Looks good now. Any chance for a unit-test though? kconf-update unit-test code is a \
bit weird, let me know if you need some explanation there.

- Aurélien


On 2010-06-07 09:22:31, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4243/
> -----------------------------------------------------------
> 
> (Updated 2010-06-07 09:22:31)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Currently, when kconf_update is being run by kdeinit4 on a new user account, it \
> creates all config files that it has updates for, regardless whether these files \
> exist. Which mean .kde/share/config gets populated with a lot of files with only \
> kconf_update's entry in them. 
> Unfortunately that means that programs checking for a specific file's existance, \
> e.g. PIM apps which are checking whether to run a migrator tool, will be fooled \
> into assuming that there are actually valid settings. 
> The patch uses the already set m_skipFile flag to decide when not to sync the \
> KConfig object, thus not creating the file if it didn't exist before 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kconf_update/kconf_update.cpp 1135402 
> 
> Diff: http://reviewboard.kde.org/r/4243/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]