[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: review request on kinfocenter/systemsettings tooltip appearance
From:       Ben Cooksley <sourtooth () gmail ! com>
Date:       2010-06-05 2:36:10
Message-ID: AANLkTikXXWt5AajXkJTs8AwPADKYq5Wuk2Q2oK2oewU8 () mail ! gmail ! com
[Download RAW message or body]

On Sat, Jun 5, 2010 at 1:34 PM, Hugo Pereira Da Costa
<hugo@oxygen-icons.org> wrote:
> Hello,
>
> This patch replaces the home-made horizontal separator in kinfocenter tooltips
> by a standard HLine frame, handled by the style, again, for consistency
> between apps.

Looks much nicer than my own written code. Thanks for the patch Hugo.

>
> Screenshots:
>
> current: http://www.flickr.com/photos/hugo-oxygen-icons-org/4670079773/
> suggested: http://www.flickr.com/photos/hugo-oxygen-icons-org/4670706386/
>
> The patch applies to
> /trunk/KDE/kdebase/workspace/kinfocenter/ToolTips
>
> Note: a similar patch should be also applied (if this one is accepted) to
> systemsettings' tooltips, which show the same custom "feature".
> (/trunk/KDE/kdebase/workspace/systemsettings/app/ToolTips)

Please feel free to commit this change to System Settings. ( where
this code originated )
The patch applied cleanly here.

>
> Comments (or instruction on where/to whom I should submit this at reviewboard)
> highly appreciated,
>
> Thanks !
>
> Hugo
>

Regards,
Ben
System Settings Maintainer.
[prev in list] [next in list] [prev in thread] [next in thread]